From f07cd645c9a0c657135e549c92db78b9cda0688c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= Date: Tue, 27 Sep 2022 16:18:23 +0000 Subject: [PATCH] [FIX] tools: don't extract missing spreadsheet data source name Previous versions of spreadsheet files don't have a name for list and pivot datasources. The spreadsheet template "pipeline dashboard" in `document_spreadsheet_crm` is such a file. As a consequence, exporting the source terms from this module fails with a `KeyError: 'name'` Part-of: odoo/odoo#101659 --- odoo/tools/translate.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/odoo/tools/translate.py b/odoo/tools/translate.py index 4a99d7bd2a7..456c14a0512 100644 --- a/odoo/tools/translate.py +++ b/odoo/tools/translate.py @@ -942,7 +942,8 @@ def extract_spreadsheet_terms(fileobj, keywords, comment_tags, options): pivots = data.get('pivots', {}).values() lists = data.get('lists', {}).values() for data_source in itertools.chain(lists, pivots): - terms.append(data_source['name']) + if 'name' in data_source: + terms.append(data_source['name']) for global_filter in data.get('globalFilters', []): terms.append(global_filter['label']) return (