From eee68139d5f9ffab23c29df22f799ea373c68008 Mon Sep 17 00:00:00 2001 From: Julien Castiaux Date: Wed, 29 Mar 2023 13:36:37 +0000 Subject: [PATCH] [IMP] test_new_api: subqueries made by search() on relational fields MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit hads a few tests that report the existing behavior (before merging subqueries WHERE clauses). task-id-3234671 Part-of: odoo/odoo#118067 Co-authored-by: Raphaël Collet --- odoo/addons/base/tests/test_expression.py | 3 + .../test_new_api/tests/test_new_fields.py | 380 ++++++++++++++++++ 2 files changed, 383 insertions(+) diff --git a/odoo/addons/base/tests/test_expression.py b/odoo/addons/base/tests/test_expression.py index bdbdd9b1503..672361226de 100644 --- a/odoo/addons/base/tests/test_expression.py +++ b/odoo/addons/base/tests/test_expression.py @@ -1216,6 +1216,9 @@ class TestQueries(TransactionCase): # search on both 'name' and 'model' self.assertEqual(Model._rec_names_search, ['name', 'model']) + # warmup + Model.name_search('foo') + Model.name_search('partner') with self.assertQueries([''' SELECT "ir_model"."id" diff --git a/odoo/addons/test_new_api/tests/test_new_fields.py b/odoo/addons/test_new_api/tests/test_new_fields.py index 9a5ea4f3e79..99132476507 100644 --- a/odoo/addons/test_new_api/tests/test_new_fields.py +++ b/odoo/addons/test_new_api/tests/test_new_fields.py @@ -3791,6 +3791,386 @@ def update(model, *fnames): ) +class TestSubqueries(common.TransactionCase): + """ Test the subqueries made by search() with relational fields. """ + maxDiff = None + + def test_and_many2one_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE ("res_partner"."name"::text LIKE %s) + )) AND ("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE ("res_partner"."phone"::text LIKE %s) + ))) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + ('partner.name', 'like', 'jack'), + ('partner.phone', 'like', '01234'), + ]) + + def test_or_many2one_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE ("res_partner"."name"::text LIKE %s) + )) OR ("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE ("res_partner"."phone"::text LIKE %s) + ))) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + '|', + ('partner.name', 'like', 'jack'), + ('partner.phone', 'like', '01234'), + ]) + + def test_not_and_many2one_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE (("res_partner"."name"::text NOT LIKE %s) OR "res_partner"."name" IS NULL) + )) OR ("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE (("res_partner"."phone"::text NOT LIKE %s) OR "res_partner"."phone" IS NULL) + ))) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + '!', '&', + ('partner.name', 'like', 'jack'), + ('partner.phone', 'like', '01234'), + ]) + + def test_not_or_many2one_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE (("res_partner"."name"::text NOT LIKE %s) OR "res_partner"."name" IS NULL) + )) AND ("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE (("res_partner"."phone"::text NOT LIKE %s) OR "res_partner"."phone" IS NULL) + ))) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + '!', '|', + ('partner.name', 'like', 'jack'), + ('partner.phone', 'like', '01234'), + ]) + + def test_or_autojoined_many2one_with_subfield(self): + self.patch(self.env['test_new_api.multi']._fields['partner'], 'auto_join', True) + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + LEFT JOIN "res_partner" AS "test_new_api_multi__partner" + ON ("test_new_api_multi"."partner" = "test_new_api_multi__partner"."id") + WHERE ( + ("test_new_api_multi__partner"."name"::text LIKE %s) + OR ("test_new_api_multi__partner"."phone"::text LIKE %s) + ) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + '|', + ('partner.name', 'like', 'jack'), + ('partner.phone', 'like', '01234'), + ]) + + def test_not_or_autojoined_many2one_with_subfield(self): + self.patch(self.env['test_new_api.multi']._fields['partner'], 'auto_join', True) + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + LEFT JOIN "res_partner" AS "test_new_api_multi__partner" + ON ("test_new_api_multi"."partner" = "test_new_api_multi__partner"."id") + WHERE ( + (("test_new_api_multi__partner"."name"::text NOT LIKE %s) + OR "test_new_api_multi__partner"."name" IS NULL) + AND (("test_new_api_multi__partner"."phone"::text NOT LIKE %s) + OR "test_new_api_multi__partner"."phone" IS NULL) + ) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + '!', '|', + ('partner.name', 'like', 'jack'), + ('partner.phone', 'like', '01234'), + ]) + + def test_mixed_and_or_many2one_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE ("res_partner"."email"::text LIKE %s) + )) AND (( + "test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE ("res_partner"."name"::text LIKE %s) + )) OR ("test_new_api_multi"."partner" IN ( + SELECT "res_partner"."id" + FROM "res_partner" + WHERE ("res_partner"."phone"::text LIKE %s) + ) + ))) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + ('partner.email', 'like', '@sgc.us'), + '|', + ('partner.name', 'like', 'jack'), + ('partner.phone', 'like', '01234'), + ]) + + def test_mixed_and_or_not_many2one_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE ( + ( + ( + ({many2one} IN ( + {subselect} WHERE ("res_partner"."function"::text LIKE %s) + )) OR ( + ({many2one} IN ( + {subselect} WHERE (("res_partner"."phone"::text NOT LIKE %s) OR "res_partner"."phone" IS NULL) + )) OR ({many2one} IN ( + {subselect} WHERE (("res_partner"."mobile"::text NOT LIKE %s) OR "res_partner"."mobile" IS NULL) + )) + ) + ) AND ({many2one} IN ( + {subselect} WHERE (("res_partner"."website"::text NOT LIKE %s) OR "res_partner"."website" IS NULL) + )) + ) AND ( + ({many2one} IN ( + {subselect} WHERE ("res_partner"."name"::text LIKE %s) + )) OR ({many2one} IN ( + {subselect} WHERE ("res_partner"."email"::text LIKE %s) + )) + ) + ) + ORDER BY "test_new_api_multi"."id" + """.format( + many2one='"test_new_api_multi"."partner"', + subselect='SELECT "res_partner"."id" FROM "res_partner"', + )]): + # (function or not (phone and mobile)) and not website and (name or email) + self.env['test_new_api.multi'].search([ + '&', '&', + '|', + ('partner.function', 'like', 'Colonel'), + '!', '&', + ('partner.phone', 'like', '+01'), + ('partner.mobile', 'like', '+01'), + '!', ('partner.website', 'like', 'sgc.us'), + '|', + ('partner.name', 'like', 'jack'), + ('partner.email', 'like', '@sgc.us'), + ]) + + def test_and_one2many_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (("test_new_api_multi"."id" IN ( + SELECT "test_new_api_multi_line"."multi" + FROM "test_new_api_multi_line" + WHERE ("test_new_api_multi_line"."name"::text LIKE %s) + AND "test_new_api_multi_line"."multi" IS NOT NULL + )) AND ("test_new_api_multi"."id" IN ( + SELECT "test_new_api_multi_line"."multi" + FROM "test_new_api_multi_line" + WHERE ("test_new_api_multi_line"."name"::text LIKE %s) + AND "test_new_api_multi_line"."multi" IS NOT NULL + ))) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + ('lines.name', 'like', 'x'), + ('lines.name', 'like', 'y'), + ]) + + def test_or_one2many_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (("test_new_api_multi"."id" IN ( + SELECT "test_new_api_multi_line"."multi" + FROM "test_new_api_multi_line" + WHERE ("test_new_api_multi_line"."name"::text LIKE %s) + AND "test_new_api_multi_line"."multi" IS NOT NULL + )) OR ("test_new_api_multi"."id" IN ( + SELECT "test_new_api_multi_line"."multi" + FROM "test_new_api_multi_line" + WHERE ("test_new_api_multi_line"."name"::text LIKE %s) + AND "test_new_api_multi_line"."multi" IS NOT NULL + ))) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + '|', + ('lines.name', 'like', 'x'), + ('lines.name', 'like', 'y'), + ]) + + def test_mixed_and_or_one2many_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (("test_new_api_multi"."id" IN ( + SELECT "test_new_api_multi_line"."multi" + FROM "test_new_api_multi_line" + WHERE ("test_new_api_multi_line"."name"::text LIKE %s) + AND "test_new_api_multi_line"."multi" IS NOT NULL + )) AND (( + "test_new_api_multi"."id" IN ( + SELECT "test_new_api_multi_line"."multi" + FROM "test_new_api_multi_line" + WHERE ("test_new_api_multi_line"."name"::text LIKE %s) + AND "test_new_api_multi_line"."multi" IS NOT NULL + )) OR ("test_new_api_multi"."id" IN ( + SELECT "test_new_api_multi_line"."multi" + FROM "test_new_api_multi_line" + WHERE ("test_new_api_multi_line"."name"::text LIKE %s) + AND "test_new_api_multi_line"."multi" IS NOT NULL + )) + )) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + ('lines.name', 'like', 'x'), + '|', + ('lines.name', 'like', 'y'), + ('lines.name', 'like', 'z'), + ]) + + def test_and_many2many_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (EXISTS ( + SELECT 1 + FROM "test_new_api_multi_test_new_api_multi_tag_rel" AS "test_new_api_multi__tags" + WHERE "test_new_api_multi__tags"."test_new_api_multi_id" = "test_new_api_multi"."id" + AND "test_new_api_multi__tags"."test_new_api_multi_tag_id" IN ( + SELECT "test_new_api_multi_tag"."id" + FROM "test_new_api_multi_tag" + WHERE ("test_new_api_multi_tag"."name"::text LIKE %s) + ) + ) AND EXISTS ( + SELECT 1 + FROM "test_new_api_multi_test_new_api_multi_tag_rel" AS "test_new_api_multi__tags" + WHERE "test_new_api_multi__tags"."test_new_api_multi_id" = "test_new_api_multi"."id" + AND "test_new_api_multi__tags"."test_new_api_multi_tag_id" IN ( + SELECT "test_new_api_multi_tag"."id" + FROM "test_new_api_multi_tag" + WHERE ("test_new_api_multi_tag"."name"::text LIKE %s) + ) + )) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + ('tags.name', 'like', 'x'), + ('tags.name', 'like', 'y'), + ]) + + def test_or_many2many_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (EXISTS ( + SELECT 1 + FROM "test_new_api_multi_test_new_api_multi_tag_rel" AS "test_new_api_multi__tags" + WHERE "test_new_api_multi__tags"."test_new_api_multi_id" = "test_new_api_multi"."id" + AND "test_new_api_multi__tags"."test_new_api_multi_tag_id" IN ( + SELECT "test_new_api_multi_tag"."id" + FROM "test_new_api_multi_tag" + WHERE ("test_new_api_multi_tag"."name"::text LIKE %s) + )) OR EXISTS ( + SELECT 1 + FROM "test_new_api_multi_test_new_api_multi_tag_rel" AS "test_new_api_multi__tags" + WHERE "test_new_api_multi__tags"."test_new_api_multi_id" = "test_new_api_multi"."id" + AND "test_new_api_multi__tags"."test_new_api_multi_tag_id" IN ( + SELECT "test_new_api_multi_tag"."id" + FROM "test_new_api_multi_tag" + WHERE ("test_new_api_multi_tag"."name"::text LIKE %s) + ))) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + '|', + ('tags.name', 'like', 'x'), + ('tags.name', 'like', 'y'), + ]) + + def test_mixed_and_or_many2many_with_subfield(self): + with self.assertQueries([""" + SELECT "test_new_api_multi"."id" + FROM "test_new_api_multi" + WHERE (EXISTS ( + SELECT 1 + FROM "test_new_api_multi_test_new_api_multi_tag_rel" AS "test_new_api_multi__tags" + WHERE "test_new_api_multi__tags"."test_new_api_multi_id" = "test_new_api_multi"."id" + AND "test_new_api_multi__tags"."test_new_api_multi_tag_id" IN ( + SELECT "test_new_api_multi_tag"."id" + FROM "test_new_api_multi_tag" + WHERE ("test_new_api_multi_tag"."name"::text LIKE %s) + ) + ) AND ( + EXISTS ( + SELECT 1 + FROM "test_new_api_multi_test_new_api_multi_tag_rel" AS "test_new_api_multi__tags" + WHERE "test_new_api_multi__tags"."test_new_api_multi_id" = "test_new_api_multi"."id" + AND "test_new_api_multi__tags"."test_new_api_multi_tag_id" IN ( + SELECT "test_new_api_multi_tag"."id" + FROM "test_new_api_multi_tag" + WHERE ("test_new_api_multi_tag"."name"::text LIKE %s) + ) + ) OR EXISTS ( + SELECT 1 + FROM "test_new_api_multi_test_new_api_multi_tag_rel" AS "test_new_api_multi__tags" + WHERE "test_new_api_multi__tags"."test_new_api_multi_id" = "test_new_api_multi"."id" + AND "test_new_api_multi__tags"."test_new_api_multi_tag_id" IN ( + SELECT "test_new_api_multi_tag"."id" + FROM "test_new_api_multi_tag" + WHERE ("test_new_api_multi_tag"."name"::text LIKE %s) + ) + ) + )) + ORDER BY "test_new_api_multi"."id" + """]): + self.env['test_new_api.multi'].search([ + ('tags.name', 'like', 'x'), + '|', + ('tags.name', 'like', 'y'), + ('tags.name', 'like', 'z'), + ]) + + class TestComputeQueries(common.TransactionCase): """ Test the queries made by create() with computed fields. """