From eed3f1bc59a23502c307bf457b65f2ff8a804f70 Mon Sep 17 00:00:00 2001
From: qsm-odoo <qsm@odoo.com>
Date: Tue, 11 Oct 2022 15:18:50 +0000
Subject: [PATCH] [FIX] website, *: hide page options for non-designer users

*: website_blog, website_crm_partner_assign, website_customer,
   website_event, website_event_exhibitor, website_event_meet,
   website_event_track, website_forum, website_hr_recruitment,
   website_membership, website_sale, website_sale_loyalty,
   website_sale_slides, website_slides, website_slides_forum

With commit [1], the "customize_show" options were moved in edit mode.
They were wrongly displayed for non-designer users. Trying to use those
would throw a warning at the user.

[1]: https://github.com/odoo/odoo/commit/17a8a37e9bfc5b787d9666597d43e63f0064919f

closes odoo/odoo#103142

X-original-commit: f2ca62a4a9ccb6713a39c100fc87c112619eac41
Related: odoo/enterprise#32768
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
---
 addons/website/views/snippets/snippets.xml           | 4 ++--
 addons/website_blog/views/snippets/snippets.xml      | 4 ++--
 addons/website_crm_partner_assign/views/snippets.xml | 3 +--
 addons/website_customer/views/snippets.xml           | 2 +-
 addons/website_event/views/snippets/snippets.xml     | 6 +++---
 addons/website_event_exhibitor/views/snippets.xml    | 4 ++--
 addons/website_event_meet/views/snippets.xml         | 2 +-
 addons/website_event_track/views/snippets.xml        | 4 ++--
 addons/website_forum/views/snippets/snippets.xml     | 2 +-
 addons/website_hr_recruitment/views/snippets.xml     | 2 +-
 addons/website_membership/views/snippets.xml         | 2 +-
 addons/website_sale/views/snippets/snippets.xml      | 6 +++---
 addons/website_sale_loyalty/views/snippets.xml       | 2 +-
 addons/website_sale_slides/views/snippets.xml        | 2 +-
 addons/website_slides/views/slide_snippets.xml       | 4 ++--
 addons/website_slides_forum/views/snippets.xml       | 2 +-
 16 files changed, 25 insertions(+), 26 deletions(-)

diff --git a/addons/website/views/snippets/snippets.xml b/addons/website/views/snippets/snippets.xml
index 8752c5a6351..08dcdc442b7 100644
--- a/addons/website/views/snippets/snippets.xml
+++ b/addons/website/views/snippets/snippets.xml
@@ -1615,13 +1615,13 @@
         </we-row>
     </div>
     <!-- Info page ('/website/info') -->
-    <div data-selector="main:has(.o_website_info)" data-page-options="true" data-no-check="true" string="Info Page">
+    <div data-selector="main:has(.o_website_info)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Info Page">
         <we-checkbox string="Odoo Information"
                         data-customize-website-views="website.show_website_info"
                         data-no-preview="true"
                         data-reload="/"/>
     </div>
-    <div data-selector="#wrapwrap > main" data-no-check="true" data-js="SwitchableViews">
+    <div data-js="SwitchableViews" data-selector="#wrapwrap > main" data-no-check="true" groups="website.group_website_designer">
             <!-- Options will be populated by JS -->
     </div>
 
diff --git a/addons/website_blog/views/snippets/snippets.xml b/addons/website_blog/views/snippets/snippets.xml
index 16251a77dd6..70d7c1058fc 100644
--- a/addons/website_blog/views/snippets/snippets.xml
+++ b/addons/website_blog/views/snippets/snippets.xml
@@ -18,7 +18,7 @@
                 data-create-method="createTag"/>
         </div>
         <!-- Blog Posts page  -->
-        <div data-selector="main:has(#o_wblog_index_content)" data-page-options="true" data-no-check="true" string="Blogs Page">
+        <div data-selector="main:has(#o_wblog_index_content)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Blogs Page">
             <we-select string="Top Banner" data-no-preview="true" data-reload="/">
                 <we-button data-customize-website-views="website_blog.opt_blog_cover_post"
                     data-name="blog_cover_opt">Name / Latest Post</we-button>
@@ -88,7 +88,7 @@
                          data-reload="/"/>
         </div>
         <!-- Blog Post page  -->
-        <div data-selector="main:has(#o_wblog_post_main)" data-page-options="true" data-no-check="true" string="Blog Page">
+        <div data-selector="main:has(#o_wblog_post_main)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Blog Page">
             <we-select string="Layout" data-no-preview="true" data-reload="/">
                 <we-button data-customize-website-views="website_blog.opt_blog_post_regular_cover">Title Above Cover</we-button>
                 <we-button data-customize-website-views="">Title Inside Cover</we-button>
diff --git a/addons/website_crm_partner_assign/views/snippets.xml b/addons/website_crm_partner_assign/views/snippets.xml
index 50734e5b8da..13d2a843e91 100644
--- a/addons/website_crm_partner_assign/views/snippets.xml
+++ b/addons/website_crm_partner_assign/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Crm Partner Assign Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(#oe_structure_website_crm_partner_assign_layout_1)" data-page-options="true" data-no-check="true" string="Partners Page">
+        <div data-selector="main:has(#oe_structure_website_crm_partner_assign_layout_1)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Partners Page">
             <we-checkbox string="Show Leads / Opps"
                          data-customize-website-views="website_crm_partner_assign.portal_my_home_lead"
                          data-no-preview="true"
@@ -17,4 +17,3 @@
 </template>
 
 </odoo>
-
diff --git a/addons/website_customer/views/snippets.xml b/addons/website_customer/views/snippets.xml
index f776ce82bc6..c21fd8955e6 100644
--- a/addons/website_customer/views/snippets.xml
+++ b/addons/website_customer/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Customer Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(#ref_left_column)" data-page-options="true" data-no-check="true" string="References Page">
+        <div data-selector="main:has(#ref_left_column)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="References Page">
             <we-checkbox string="Countries Filter"
                          data-customize-website-views="website_customer.opt_country_list"
                          data-no-preview="true"
diff --git a/addons/website_event/views/snippets/snippets.xml b/addons/website_event/views/snippets/snippets.xml
index aa373922d0e..66bb773833f 100644
--- a/addons/website_event/views/snippets/snippets.xml
+++ b/addons/website_event/views/snippets/snippets.xml
@@ -14,7 +14,7 @@
 <template id="snippet_options" inherit_id="website.snippet_options" name="Event snippet options">
     <xpath expr="." position="inside">
         <!-- Events page  -->
-        <div data-selector="main:has(.o_wevent_events_list)" data-page-options="true" data-no-check="true" string="Events Page">
+        <div data-selector="main:has(.o_wevent_events_list)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Events Page">
             <we-select string="Layout" data-no-preview="true" data-reload="/">
                 <we-button data-customize-website-views="website_event.opt_events_list_columns">Grid</we-button>
                 <we-button data-customize-website-views="">List</we-button>
@@ -70,13 +70,13 @@
                          data-reload="/"/>
         </div>
         <!-- Event page  -->
-        <div data-selector="main:has(.o_wevent_event_title)" data-page-options="true" data-no-check="true" string="Event Page">
+        <div data-selector="main:has(.o_wevent_event_title)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Event Page">
             <we-checkbox string="Fold Tickets Details"
                          data-customize-website-views="website_event.fold_register_details"
                          data-no-preview="true"
                          data-reload="/"/>
         </div>
-        <div data-js="WebsiteEvent" data-selector="main:has(.o_wevent_event)" data-page-options="true" data-no-check="true" string="Event Page">
+        <div data-js="WebsiteEvent" data-selector="main:has(.o_wevent_event)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Event Page">
             <we-checkbox string="Sub-menu (Specific)"
                          data-display-submenu="true"
                          data-no-preview="true"
diff --git a/addons/website_event_exhibitor/views/snippets.xml b/addons/website_event_exhibitor/views/snippets.xml
index 5159d9d095e..0ce217b3df4 100644
--- a/addons/website_event_exhibitor/views/snippets.xml
+++ b/addons/website_event_exhibitor/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Event exhibitor snippet options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(nav .o_wevent_event_tags_form)" data-page-options="true" data-no-check="true" string="Event Page">
+        <div data-selector="main:has(nav .o_wevent_event_tags_form)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Event Page">
             <we-row string="Top Bar Filter" class="o_we_full_row">
                 <we-button string="Sponsorship"
                            data-customize-website-views="website_event_exhibitor.exhibitors_topbar_sponsorship"
@@ -15,7 +15,7 @@
                            data-reload="/"/>
             </we-row>
         </div>
-        <div data-selector="main:has(.o_wevent_event)" data-page-options="true" data-no-check="true" string="Event Page">
+        <div data-selector="main:has(.o_wevent_event)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Event Page">
             <we-checkbox string="Sponsors"
                          data-customize-website-views="website_event_exhibitor.event_sponsor"
                          data-no-preview="true"
diff --git a/addons/website_event_meet/views/snippets.xml b/addons/website_event_meet/views/snippets.xml
index c786580e5f6..6ec8c8c62f9 100644
--- a/addons/website_event_meet/views/snippets.xml
+++ b/addons/website_event_meet/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Event Meet Snippet Options">
     <xpath expr="." position="inside">
-        <div data-js="WebsiteEvent" data-selector="main:has(.o_wemeet_container)" data-page-options="true" data-no-check="true" string="Event Page">
+        <div data-js="WebsiteEvent" data-selector="main:has(.o_wemeet_container)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Event Page">
             <we-checkbox string="Room Creation (Specific)"
                          data-allow-room-creation="true"
                          data-no-preview="true"
diff --git a/addons/website_event_track/views/snippets.xml b/addons/website_event_track/views/snippets.xml
index 9960949afe7..a39834ca11e 100644
--- a/addons/website_event_track/views/snippets.xml
+++ b/addons/website_event_track/views/snippets.xml
@@ -3,13 +3,13 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Event track snippet options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(.o_weagenda_topbar_filters)" data-page-options="true" data-no-check="true" string="Event Page">
+        <div data-selector="main:has(.o_weagenda_topbar_filters)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Event Page">
             <we-checkbox string="Wishlists"
                          data-customize-website-views="website_event_track.agenda_topbar_wishlist"
                          data-no-preview="true"
                          data-reload="/"/>
         </div>
-        <div data-selector="main:has(.o_wesession_index)" data-page-options="true" data-no-check="true" string="Event Page">
+        <div data-selector="main:has(.o_wesession_index)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Event Page">
             <we-checkbox string="Wishlists"
                          data-customize-website-views="website_event_track.session_topbar_wishlist"
                          data-no-preview="true"
diff --git a/addons/website_forum/views/snippets/snippets.xml b/addons/website_forum/views/snippets/snippets.xml
index 680fe8ffa27..3494bb46b3e 100644
--- a/addons/website_forum/views/snippets/snippets.xml
+++ b/addons/website_forum/views/snippets/snippets.xml
@@ -20,7 +20,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Forum Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(#o_wforum_forums_index_list)" data-page-options="true" data-no-check="true" string="Forum Page">
+        <div data-selector="main:has(#o_wforum_forums_index_list)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Forum Page">
             <we-select string="Layout" data-no-preview="true" data-reload="/">
                 <we-button data-customize-website-views="">Grid</we-button>
                 <we-button data-customize-website-views="website_forum.opt_list_view">List</we-button>
diff --git a/addons/website_hr_recruitment/views/snippets.xml b/addons/website_hr_recruitment/views/snippets.xml
index 0174555aeb0..2ca85342fab 100644
--- a/addons/website_hr_recruitment/views/snippets.xml
+++ b/addons/website_hr_recruitment/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Hr Recruitment Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(.o_website_hr_recruitment_jobs_list)" data-page-options="true" data-no-check="true" string="Jobs Page">
+        <div data-selector="main:has(.o_website_hr_recruitment_jobs_list)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Jobs Page">
             <we-checkbox string="Countries Filter"
                          data-customize-website-views="website_hr_recruitment.job_filter_by_countries"
                          data-no-preview="true"
diff --git a/addons/website_membership/views/snippets.xml b/addons/website_membership/views/snippets.xml
index 3b97203bb2f..9acb2da488d 100644
--- a/addons/website_membership/views/snippets.xml
+++ b/addons/website_membership/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Membership Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(#oe_structure_website_membership_index_1)" data-page-options="true" data-no-check="true" string="Members Page">
+        <div data-selector="main:has(#oe_structure_website_membership_index_1)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Members Page">
             <we-checkbox string="Location"
                          data-customize-website-views="website_membership.opt_index_country"
                          data-no-preview="true"
diff --git a/addons/website_sale/views/snippets/snippets.xml b/addons/website_sale/views/snippets/snippets.xml
index 211c7fda4c9..9252f0d23e0 100644
--- a/addons/website_sale/views/snippets/snippets.xml
+++ b/addons/website_sale/views/snippets/snippets.xml
@@ -13,7 +13,7 @@
 <template id="snippet_options" inherit_id="website.snippet_options" name="e-commerce snippet options">
     <xpath expr="." position="inside">
         <!-- All products page -->
-        <div data-js="WebsiteSaleGridLayout" data-page-options="true" data-selector="main:has(.o_wsale_products_page)" data-no-check="true"
+        <div data-js="WebsiteSaleGridLayout" data-page-options="true" groups="website.group_website_designer" data-selector="main:has(.o_wsale_products_page)" data-no-check="true"
             string="Products Page" data-target="#products_grid .o_wsale_products_grid_table_wrapper > table">
             <we-select string="Layout" data-no-preview="true" data-reload="/">
                 <we-button data-customize-website-views="" data-name="grid_view_opt">Grid</we-button>
@@ -214,7 +214,7 @@
             </we-select>
         </div>
         <!-- Product page -->
-        <div data-js="WebsiteSaleProductPage" data-selector="main:has(.o_wsale_product_page)" data-page-options="true" data-no-check="true" string="Product Page">
+        <div data-js="WebsiteSaleProductPage" data-selector="main:has(.o_wsale_product_page)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Product Page">
             <we-row string="Customers" class="o_we_full_row">
                 <we-button string="Rating"
                            data-customize-website-views="website_sale.product_comment"
@@ -285,7 +285,7 @@
             </we-row>
         </div>
         <!-- Checkout page  -->
-        <div data-selector="main:has(.oe_website_sale .wizard)" data-page-options="true" data-no-check="true" string="Checkout Pages">
+        <div data-selector="main:has(.oe_website_sale .wizard)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Checkout Pages">
             <we-checkbox string="Extra Step Option"
                          data-customize-website-views="website_sale.extra_info_option"
                          data-no-preview="true"
diff --git a/addons/website_sale_loyalty/views/snippets.xml b/addons/website_sale_loyalty/views/snippets.xml
index 7fb2eedf4f7..8e23aad49af 100644
--- a/addons/website_sale_loyalty/views/snippets.xml
+++ b/addons/website_sale_loyalty/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Coupon Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(.oe_website_sale .wizard)" data-page-options="true" data-no-check="true">
+        <div data-selector="main:has(.oe_website_sale .wizard)" data-page-options="true" groups="website.group_website_designer" data-no-check="true">
             <we-checkbox string="Show Discount in Subtotal"
                          data-customize-website-views="website_sale_loyalty.cart_discount"
                          data-no-preview="true"
diff --git a/addons/website_sale_slides/views/snippets.xml b/addons/website_sale_slides/views/snippets.xml
index 497def0b981..b969e380854 100644
--- a/addons/website_sale_slides/views/snippets.xml
+++ b/addons/website_sale_slides/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Slides Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(.o_wslides_course_header)" data-page-options="true" data-no-check="true" string="Course Page">
+        <div data-selector="main:has(.o_wslides_course_header)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Course Page">
             <we-checkbox string="Buy Now Button"
                          data-customize-website-views="website_sale_slides.course_option_buy_course_now"
                          data-no-preview="true"
diff --git a/addons/website_slides/views/slide_snippets.xml b/addons/website_slides/views/slide_snippets.xml
index e995037c271..a050bfa1213 100644
--- a/addons/website_slides/views/slide_snippets.xml
+++ b/addons/website_slides/views/slide_snippets.xml
@@ -20,13 +20,13 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Slides Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(.o_wslides_home_main)" data-page-options="true" data-no-check="true" string="Courses Page">
+        <div data-selector="main:has(.o_wslides_home_main)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Courses Page">
             <we-checkbox string="New Content Ribbon"
                          data-customize-website-views="website_slides.course_card_information_arrow"
                          data-no-preview="true"
                          data-reload="/"/>
         </div>
-        <div data-selector="main:has(.o_wslides_home_aside_loggedin)" data-page-options="true" data-no-check="true" string="Courses Page">
+        <div data-selector="main:has(.o_wslides_home_aside_loggedin)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Courses Page">
             <we-checkbox string="Achievements"
                          data-customize-website-views="website_slides.toggle_latest_achievements"
                          data-no-preview="true"
diff --git a/addons/website_slides_forum/views/snippets.xml b/addons/website_slides_forum/views/snippets.xml
index 2cd5a085720..2b8f7342db5 100644
--- a/addons/website_slides_forum/views/snippets.xml
+++ b/addons/website_slides_forum/views/snippets.xml
@@ -3,7 +3,7 @@
 
 <template id="snippet_options" inherit_id="website.snippet_options" name="Slides Forum Snippet Options">
     <xpath expr="." position="inside">
-        <div data-selector="main:has(#o_wforum_forums_index_list)" data-page-options="true" data-no-check="true" string="Forum Page">
+        <div data-selector="main:has(#o_wforum_forums_index_list)" data-page-options="true" groups="website.group_website_designer" data-no-check="true" string="Forum Page">
             <we-checkbox string="Separate Courses"
                          class="o_we_sublevel_1"
                          data-customize-website-views="website_slides_forum.website_slides_forum_index"