From ee95f41dbfc74c24f3198464e26d9a381ee17243 Mon Sep 17 00:00:00 2001
From: "stefanorigano (SRI)" <sri@odoo.com>
Date: Tue, 22 Mar 2022 10:58:21 +0000
Subject: [PATCH] [FIX] web: `o_searchview` design consistency

Review 'o_searchview' menu entries design, improving consistency within
the overall UI.
Part of the overall v16 SCSS optimization/restyle, task-2704984.

task-2800721

Part-of: odoo/odoo#87448
---
 addons/web/static/src/legacy/xml/base.xml                 | 8 ++++----
 addons/web/static/src/search/search_bar/search_bar.xml    | 4 ++--
 .../web/static/src/search/search_panel/search_view.scss   | 4 +---
 .../static/src/search/search_panel/search_view_extra.scss | 6 ------
 4 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/addons/web/static/src/legacy/xml/base.xml b/addons/web/static/src/legacy/xml/base.xml
index 7736012f839..b008922a0c8 100644
--- a/addons/web/static/src/legacy/xml/base.xml
+++ b/addons/web/static/src/legacy/xml/base.xml
@@ -370,7 +370,7 @@
         <ul t-if="state.sources.length" class="dropdown-menu o_searchview_autocomplete dropdown-menu show" role="menu">
             <li t-foreach="state.sources" t-as="src" t-key="src.id"
                 t-att-id="src.id"
-                class="o_menu_item"
+                class="o_menu_item dropdown-item"
                 t-att-class="{ o_indent: src.parent and !src.parent.selection, o_selection_focus: src_index === state.focusedItem }"
                 t-on-click="()=>this._selectSource(src)"
                 t-on-mousemove="()=>this._onSourceMousemove(src_index)"
@@ -384,12 +384,12 @@
                 </a>
                 <a href="#" t-on-click.prevent="">
                     <t t-if="src.parent.selection">
-                        Search <em t-esc="src.parent.description"/>: <strong t-esc="src.label"/></t>
+                        Search <b t-esc="src.parent.description"/>: <b class="font-italic text-primary" t-esc="src.label"/></t>
                     <t t-elif="src.label" t-esc="src.label"/>
                     <t t-elif="['date', 'datetime'].includes(src.type)">
-                        <t>Search <em t-esc="src.description"/> at: <strong t-esc="state.inputValue"/></t>
+                        <t>Search <b t-esc="src.description"/> at: <b class="font-italic text-primary" t-esc="state.inputValue"/></t>
                     </t>
-                    <t t-else="">Search <em t-esc="src.description"/> for: <strong t-esc="state.inputValue"/></t>
+                    <t t-else="">Search <b t-esc="src.description"/> for: <b class="font-italic text-primary" t-esc="state.inputValue"/></t>
                 </a>
             </li>
         </ul>
diff --git a/addons/web/static/src/search/search_bar/search_bar.xml b/addons/web/static/src/search/search_bar/search_bar.xml
index fb20e9d1159..d6210f8603d 100644
--- a/addons/web/static/src/search/search_bar/search_bar.xml
+++ b/addons/web/static/src/search/search_bar/search_bar.xml
@@ -48,7 +48,7 @@
     <t t-name="web.SearchBar.Items" owl="1">
         <ul class="dropdown-menu o_searchview_autocomplete dropdown-menu show" role="menu">
             <t t-foreach="items" t-as="item" t-key="item.id">
-                <li class="o_menu_item"
+                <li class="o_menu_item dropdown-item"
                     t-att-class="{ o_indent: item.isChild, o_selection_focus: item_index === state.focusedIndex}"
                     t-att-id="item.id"
                     t-on-click="() => this.selectItem(item)"
@@ -67,7 +67,7 @@
                             <t t-esc="item.label"/>
                         </t>
                         <t t-else="">
-                            Search <em t-esc="item.searchItemDescription"/> <t t-esc="item.preposition"/>: <strong t-esc="item.label"/>
+                            Search <b t-esc="item.searchItemDescription"/> <t t-esc="item.preposition"/>: <b class="font-italic text-primary" t-esc="item.label"/>
                         </t>
                     </a>
                 </li>
diff --git a/addons/web/static/src/search/search_panel/search_view.scss b/addons/web/static/src/search/search_panel/search_view.scss
index f6cf86a3b23..9a355cef0c4 100644
--- a/addons/web/static/src/search/search_panel/search_view.scss
+++ b/addons/web/static/src/search/search_panel/search_view.scss
@@ -64,9 +64,7 @@
                 }
 
                 a {
-                    &:hover {
-                        background-color: inherit;
-                    }
+                    color: inherit;
 
                     &.o_expand {
                         display: flex;
diff --git a/addons/web/static/src/search/search_panel/search_view_extra.scss b/addons/web/static/src/search/search_panel/search_view_extra.scss
index 2530f060c08..ab13505eb6d 100644
--- a/addons/web/static/src/search/search_panel/search_view_extra.scss
+++ b/addons/web/static/src/search/search_panel/search_view_extra.scss
@@ -27,10 +27,4 @@
     .o_searchview_icon {
         @include o-position-absolute($top: 6px, $right: 5px);
     }
-    .o_searchview_autocomplete li.o_selection_focus {
-        background-color: $o-brand-odoo;
-        > a {
-            color: white;
-        }
-    }
 }