From ee61cc4259492572f5ce64a43b314e4fa28e30b8 Mon Sep 17 00:00:00 2001 From: "Didier (did)" Date: Wed, 6 Jul 2022 11:53:49 +0000 Subject: [PATCH] [FIX] mail: correctly return a field command when guest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, field command was returning incorrect value if the channel_partner was a guest. At the very least we have to return a `clear` command. closes odoo/odoo#95411 Signed-off-by: Sébastien Theys (seb) --- addons/mail/models/mail_channel.py | 2 +- addons/mail/static/src/models/channel_member.js | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/addons/mail/models/mail_channel.py b/addons/mail/models/mail_channel.py index 7258a64448d..3682e8101a9 100644 --- a/addons/mail/models/mail_channel.py +++ b/addons/mail/models/mail_channel.py @@ -1183,7 +1183,7 @@ class Channel(models.Model): 'id': member.partner_id.id, 'name': member.partner_id.name, 'im_status': member.partner_id.im_status, - })] + })] if member.partner_id else [('clear',)], } for member in channel_partners])], 'memberCount': count, } diff --git a/addons/mail/static/src/models/channel_member.js b/addons/mail/static/src/models/channel_member.js index 747fe126e91..59fd64de270 100644 --- a/addons/mail/static/src/models/channel_member.js +++ b/addons/mail/static/src/models/channel_member.js @@ -27,6 +27,9 @@ registerModel({ * @returns {string} */ _computeName() { + if (!this.partner) { + return; + } return this.partner.nameOrDisplayName; }, },