From ec48392e39e551d9784f0431aa818f280edf9ce3 Mon Sep 17 00:00:00 2001 From: Denis Ledoux Date: Fri, 21 Dec 2018 11:08:07 +0000 Subject: [PATCH] [TODO] service/server: note to remove override that will become useless The method override `_handle_request_noblock` is there to solve a bug in Python socketserver library which has been solved in - Python 3.6: python/cpython@8b1f52b5a93403acd7d112cd1c1bc716b31a418a, - Python 3.7: python/cpython@908082451382b8b3ba09ebba638db660edbf5d8e, through PR python/cpython#9952. These revisions will be included in Python releases 3.6.8 and 3.7.2, and the override will then become useless. We therefore can remove the `_handle_request_noblock` override as soon as the Python 3 releases installed on operating systems supported by Odoo are above - 3.6.8 for Python 3.6 - 3.7.2 for Python 3.7 closes odoo/odoo#29706 --- odoo/service/server.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/odoo/service/server.py b/odoo/service/server.py index 8ecf6143118..aa620cb8197 100644 --- a/odoo/service/server.py +++ b/odoo/service/server.py @@ -160,6 +160,11 @@ class ThreadedWSGIServerReloadable(LoggingBaseWSGIServerMixIn, werkzeug.serving. t.start_time = time.time() t.start() + # TODO: Remove this method as soon as either of the revision + # - python/cpython@8b1f52b5a93403acd7d112cd1c1bc716b31a418a for Python 3.6, + # - python/cpython@908082451382b8b3ba09ebba638db660edbf5d8e for Python 3.7, + # is included in all Python 3 releases installed on all operating systems supported by Odoo. + # These revisions are included in Python from releases 3.6.8 and Python 3.7.2 respectively. def _handle_request_noblock(self): """ In the python module `socketserver` `process_request` loop,