From ebd68aeb8322ee59c78fe843fd4ffb6c06d711e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A9ry=20Debongnie?= Date: Wed, 29 Apr 2015 09:53:11 +0200 Subject: [PATCH] [FIX] web: prevent useless rpc in one2many In some cases (for example, some popup dialogs with a form view), the one2many field is destroyed but the async code still tries to append a view manager to itself. The result is that the start method of the view manager is run, resulting in at least an useless fieldviewget. --- addons/web/static/src/js/views/form_relational_widgets.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/web/static/src/js/views/form_relational_widgets.js b/addons/web/static/src/js/views/form_relational_widgets.js index 7dacdb1d1fe..b8d0e33425d 100644 --- a/addons/web/static/src/js/views/form_relational_widgets.js +++ b/addons/web/static/src/js/views/form_relational_widgets.js @@ -850,7 +850,9 @@ var FieldOne2Many = AbstractManyField.extend({ }); }); $.async_when().done(function () { - self.viewmanager.appendTo(self.$el); + if (!self.isDestroyed()) { + self.viewmanager.appendTo(self.$el); + } }); return def; },