From eb11665bfcede0555f9b0d5f20422d2827596e56 Mon Sep 17 00:00:00 2001 From: Yannick Tivisse Date: Fri, 14 Sep 2018 11:04:49 +0200 Subject: [PATCH] [FIX] rating: Send rating if no override of rating_get_parent Purpose ======= Currently if the method rating_get_parent is not overriden, then sending a rating on a record of the model leads to a traceback. --- addons/rating/models/rating.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/addons/rating/models/rating.py b/addons/rating/models/rating.py index 7ad76ddda87..671ef7e7bd3 100644 --- a/addons/rating/models/rating.py +++ b/addons/rating/models/rating.py @@ -106,9 +106,11 @@ class Rating(models.Model): 'parent_res_id': False, } if hasattr(current_record, 'rating_get_parent'): - parent_res_model = getattr(current_record, current_record.rating_get_parent()) - data['parent_res_model_id'] = self.env['ir.model']._get(parent_res_model._name).id - data['parent_res_id'] = parent_res_model.id + current_record_parent = current_record.rating_get_parent() + if current_record_parent: + parent_res_model = getattr(current_record, current_record_parent) + data['parent_res_model_id'] = self.env['ir.model']._get(parent_res_model._name).id + data['parent_res_id'] = parent_res_model.id return data @api.multi