From eaed74dec07655636749ca62ff51f1768b2a8f58 Mon Sep 17 00:00:00 2001 From: Jeremy Cormier Date: Mon, 31 May 2021 18:50:30 +0000 Subject: [PATCH] [FIX] stock: fixed singleton in picking write method closes odoo/odoo#71535 X-original-commit: 922ee844f699fdb230b32d3f8c06ff22476f99c3 Signed-off-by: William Henrotin --- addons/stock/models/stock_picking.py | 2 +- doc/cla/corporate/subteno-it.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/stock/models/stock_picking.py b/addons/stock/models/stock_picking.py index f646b0abf1f..d00d3a06e51 100644 --- a/addons/stock/models/stock_picking.py +++ b/addons/stock/models/stock_picking.py @@ -667,7 +667,7 @@ class Picking(models.Model): return res def write(self, vals): - if vals.get('picking_type_id') and self.state != 'draft': + if vals.get('picking_type_id') and any(picking.state != 'draft' for picking in self): raise UserError(_("Changing the operation type of this record is forbidden at this point.")) # set partner as a follower and unfollow old partner if vals.get('partner_id'): diff --git a/doc/cla/corporate/subteno-it.md b/doc/cla/corporate/subteno-it.md index 1739c616579..ad90a853a5a 100644 --- a/doc/cla/corporate/subteno-it.md +++ b/doc/cla/corporate/subteno-it.md @@ -14,3 +14,5 @@ List of contributors: Christian LECOUFLE christian.lecoufle@subteno-it.fr https://github.com/cle-subteno-it Vincent COFFIN vincent.coffin@subteno-it.fr https://github.com/vco-subteno-it +Jeremy CORMIER jco@subteno.com https://github.com/jco-subteno-it +Jeremy CORMIER jeremy.cormier@subteno-it.fr https://github.com/jco-subteno-it \ No newline at end of file