From eabcf88f825440fc11b43de24f439a6badaba005 Mon Sep 17 00:00:00 2001 From: yosa-odoo Date: Mon, 12 Feb 2024 11:20:14 +0100 Subject: [PATCH] [FIX] partner_autocomplete: display autocomplete createEdit Steps to reproduce: [account, iap credit] - create a new invoice - start to write "test" for the partner Issue: The partner autocomplete is not displayed Cause: in #150106 we add a condition for the quickCreate bypassing the possibility of having createEdit set to true opw-3698400 closes odoo/odoo#155781 X-original-commit: 5f342b816c16fbbaefdb61d8bfac8376132dbfeb Signed-off-by: Louis Baudoux (lba) Signed-off-by: Yolann Sabaux (yosa) --- .../src/js/partner_autocomplete_many2one.js | 16 ++++++++++++-- .../tests/partner_autocomplete_tests.js | 22 +++++++++++++++++++ 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/addons/partner_autocomplete/static/src/js/partner_autocomplete_many2one.js b/addons/partner_autocomplete/static/src/js/partner_autocomplete_many2one.js index 7ae78a04405..23d349d9a5a 100644 --- a/addons/partner_autocomplete/static/src/js/partner_autocomplete_many2one.js +++ b/addons/partner_autocomplete/static/src/js/partner_autocomplete_many2one.js @@ -19,7 +19,7 @@ export class PartnerMany2XAutocomplete extends Many2XAutocomplete { get sources() { const sources = super.sources; - if (!this.props.quickCreate) + if (!this.props.canCreate) { return sources; } @@ -67,7 +67,19 @@ export class PartnerMany2XAutocomplete extends Many2XAutocomplete { } -export class PartnerAutoCompleteMany2one extends Many2OneField {} +PartnerMany2XAutocomplete.props = { + ...Many2XAutocomplete.props, + canCreate: { type: Boolean, optional: true }, +} + +export class PartnerAutoCompleteMany2one extends Many2OneField { + get Many2XAutocompleteProps() { + return { + ...super.Many2XAutocompleteProps, + canCreate: this.props.canCreate, + }; + } +} PartnerAutoCompleteMany2one.components = { ...Many2OneField.components, diff --git a/addons/partner_autocomplete/static/tests/partner_autocomplete_tests.js b/addons/partner_autocomplete/static/tests/partner_autocomplete_tests.js index 42c9c2bd118..6c008a8ad63 100644 --- a/addons/partner_autocomplete/static/tests/partner_autocomplete_tests.js +++ b/addons/partner_autocomplete/static/tests/partner_autocomplete_tests.js @@ -378,4 +378,26 @@ QUnit.module('partner_autocomplete', { "There should be no option when partner field has no_create attribute" ); }); + + QUnit.test("Display auto complete suggestion for canCreate", async function (assert) { + assert.expect(1); + const partnerMakeViewParams = { + ...makeViewParams, + arch: + `
+ + + ` + } + await makeView(partnerMakeViewParams); + const input = target.querySelector("[name='parent_id'] input"); + await editInputNoChangeEvent(input, "blabla"); + const autocompleteContainer = input.parentElement; + assert.containsN( + autocompleteContainer, + ".o-autocomplete--dropdown-item", + 8, + "Clearbit and Odoo autocomplete options should be shown" + ); + }); });