From ea7b5f059cc56ffc17032a3206c2bbbb354be176 Mon Sep 17 00:00:00 2001
From: Aaron Bohy <aab@odoo.com>
Date: Thu, 2 Jul 2020 12:04:12 +0000
Subject: [PATCH] [IMP] crm: crm.lead form view: set ids on duplicated fields

Some fields are duplicated in the crm.lead for views. Those having
their label manually generated must define a unique id, to be used
by the associated label. That way, all labels are associated with
the correct occurrence of their field.

Part of task 2261697

closes odoo/odoo#53950

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 addons/crm/views/crm_lead_views.xml | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index 3ccf679c4b1..88da4d16f70 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -164,23 +164,23 @@
                                 <field name="phone_blacklisted" invisible="1"/>
                                 <field name="email_state" invisible="1"/>
                                 <field name="phone_state" invisible="1"/>
-                                <label for="email_from" class="oe_inline"/>
+                                <label for="email_from_group_lead_info" class="oe_inline"/>
                                 <div class="o_row o_row_readonly">
                                     <button name="mail_action_blacklist_remove" class="fa fa-ban text-danger"
                                         title="This email is blacklisted for mass mailings. Click to unblacklist."
                                         type="object" context="{'default_email': email_from}" groups="base.group_user"
                                         attrs="{'invisible': [('is_blacklisted', '=', False)]}"/>
-                                    <field name="email_from" string="Email" widget="email"/>
+                                    <field name="email_from" id="email_from_group_lead_info" string="Email" widget="email"/>
                                 </div>
                                 <field name="email_cc" groups="base.group_no_one"/>
                                 <field name="function"/>
-                                <label for="phone" class="oe_inline"/>
+                                <label for="phone_group_lead_info" class="oe_inline"/>
                                 <div class="o_row o_row_readonly">
                                     <button name="phone_action_blacklist_remove" class="fa fa-ban text-danger"
                                         title="This phone number is blacklisted for SMS Marketing. Click to unblacklist."
                                         type="object" context="{'default_phone': phone}" groups="base.group_user"
                                         attrs="{'invisible': [('phone_blacklisted', '=', False)]}"/>
-                                    <field name="phone" widget="phone"/>
+                                    <field name="phone" id="phone_group_lead_info" widget="phone"/>
                                 </div>
                                 <label for="mobile" class="oe_inline"/>
                                 <div class="o_row o_row_readonly">
@@ -242,9 +242,9 @@
                                 <group>
                                     <group string="Contact Information">
                                         <field name="partner_name"/>
-                                        <label for="street" string="Address"/>
+                                        <label for="street_page_lead" string="Address"/>
                                         <div class="o_address_format">
-                                            <field name="street" placeholder="Street..." class="o_address_street"/>
+                                            <field name="street" id="street_page_lead" placeholder="Street..." class="o_address_street"/>
                                             <field name="street2" placeholder="Street 2..." class="o_address_street"/>
                                             <field name="city" placeholder="City" class="o_address_city"/>
                                             <field name="state_id" class="o_address_state" placeholder="State" options='{"no_open": True}'/>
@@ -255,19 +255,19 @@
                                         <field name="lang_id" options="{'no_create': True}"/>
                                     </group>
                                     <group class="mt48">
-                                        <label for="contact_name"/>
+                                        <label for="contact_name_page_lead"/>
                                         <div class="o_row">
-                                            <field name="contact_name"/>
+                                            <field name="contact_name" id="contact_name_page_lead"/>
                                             <field name="title" placeholder="Title" domain="[]" options='{"no_open": True}'/>
                                         </div>
                                         <field name="function"/>
-                                        <label for="mobile" class="oe_inline"/>
+                                        <label for="mobile_page_lead" class="oe_inline"/>
                                         <div class="o_row o_row_readonly">
                                             <button name="phone_action_blacklist_remove" class="fa fa-ban text-danger"
                                                 title="This phone number is blacklisted for SMS Marketing. Click to unblacklist."
                                                 type="object" context="{'default_phone': mobile}" groups="base.group_user"
                                                 attrs="{'invisible': [('mobile_blacklisted', '=', False)]}"/>
-                                            <field name="mobile" widget="phone"/>
+                                            <field name="mobile" id="mobile_page_lead" widget="phone"/>
                                         </div>
                                     </group>
                                     <group string="Marketing">