From ea35602ff218e76732db59afe3bf27232a387b8d Mon Sep 17 00:00:00 2001
From: "Pratik Raval (PRRA)" <prra@odoo.com>
Date: Tue, 16 May 2023 11:34:09 +0000
Subject: [PATCH] [FIX] survey: hide limit attempt field when survey_type is
 live_session

fix-up of https://github.com/odoo/odoo/commit/a0a78f807abd15cb64994aa626a48a0589e16570

Currently, When a user selects 'Live Survey' as the survey type, the
`is_attemps_limited` field is visible although it should be hidden.

This commit fixes this issue by hiding the field when the survey type
is set to 'Live survey'.

Along with that, this commit also removes the condition that hides the
`is_attemps_limited` field when there is/are conditional question(s) in the
survey.

TaskID-3326930

closes odoo/odoo#123596

X-original-commit: d5d0b97b9ada57f43b026da758a0f0044519f460
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
---
 addons/survey/views/survey_survey_views.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/survey/views/survey_survey_views.xml b/addons/survey/views/survey_survey_views.xml
index 63c172584a5..6a5162ba93f 100644
--- a/addons/survey/views/survey_survey_views.xml
+++ b/addons/survey/views/survey_survey_views.xml
@@ -107,9 +107,9 @@
                                            attrs="{'readonly': [('survey_type', '=', 'live_session')]}"/>
                                     <field name="users_login_required"/>
                                     <label for="is_attempts_limited" string="Limit Attempts"
-                                           attrs="{'invisible': ['|', '|', ('survey_type', '=', 'live_session'), ('has_conditional_questions', '=', True), '&amp;', ('access_mode', '=', 'public'), ('users_login_required', '=', False)]}"/>
+                                           attrs="{'invisible': ['|', ('survey_type', '=', 'live_session'), '&amp;', ('access_mode', '=', 'public'), ('users_login_required', '=', False)]}"/>
                                     <div class="o_checkbox_optional_field"
-                                        attrs="{'invisible': ['|', ('has_conditional_questions', '=', True), '&amp;', ('access_mode', '=', 'public'), ('users_login_required', '=', False)]}">
+                                        attrs="{'invisible': ['|', ('survey_type', '=', 'live_session'), '&amp;', ('access_mode', '=', 'public'), ('users_login_required', '=', False)]}">
                                         <field name="is_attempts_limited" nolabel="1"/>
                                         <div attrs="{'invisible': [('is_attempts_limited', '=', False)]}">
                                             to <field name="attempts_limit" nolabel="1" class="oe_inline"/> attempts