From ea1b3254bb58b762c4398dbd8a823a7a41fff6e1 Mon Sep 17 00:00:00 2001
From: Aaron Bohy <aab@odoo.com>
Date: Fri, 3 May 2019 11:56:10 +0000
Subject: [PATCH] [IMP] web: multi-line many2one: only highlight first line

Rev. a3489be33 removed this feature to fix a bug (when the single
line many2one, e.g. a product, is too long and displayed over
several lines). However, we (fp) still want this for res_partner
many2ones with show_adress.

This rev. re-introduced the feature without re-introducing the bug.

closes odoo/odoo#33139

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
---
 addons/web/static/src/js/fields/relational_fields.js   |  5 ++++-
 addons/web/static/src/scss/form_view.scss              | 10 ++++++----
 .../fields/relational_fields/field_many2one_tests.js   |  2 +-
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/addons/web/static/src/js/fields/relational_fields.js b/addons/web/static/src/js/fields/relational_fields.js
index 751c16b3a23..325e0ceb8e8 100644
--- a/addons/web/static/src/js/fields/relational_fields.js
+++ b/addons/web/static/src/js/fields/relational_fields.js
@@ -465,7 +465,10 @@ var FieldMany2One = AbstractField.extend({
      * @private
      */
     _renderReadonly: function () {
-        var value = _.escape((this.m2o_value || "").trim()).split("\n").join("<br/>");
+        var escapedValue = _.escape((this.m2o_value || "").trim());
+        var value = escapedValue.split('\n').map(function (line) {
+            return '<span>' + line + '</span>';
+        }).join('<br/>');
         this.$el.html(value);
         if (!this.noOpen && this.value) {
             this.$el.attr('href', _.str.sprintf('#id=%s&model=%s', this.value.res_id, this.field.relation));
diff --git a/addons/web/static/src/scss/form_view.scss b/addons/web/static/src/scss/form_view.scss
index 8bcaba31ee3..8d4f56624ca 100644
--- a/addons/web/static/src/scss/form_view.scss
+++ b/addons/web/static/src/scss/form_view.scss
@@ -81,10 +81,12 @@
 
     .o_form_uri {
         display: inline-block;
-        color: $link-color;
-
-        &:hover {
-            color: darken($link-color, 15%);
+        color: $o-main-text-color;
+        > span:first-child {
+            color: $link-color;
+            &:hover {
+                color: darken($link-color, 15%);
+            }
         }
     }
 
diff --git a/addons/web/static/tests/fields/relational_fields/field_many2one_tests.js b/addons/web/static/tests/fields/relational_fields/field_many2one_tests.js
index e28b8ef1a47..ed38fbbaf03 100644
--- a/addons/web/static/tests/fields/relational_fields/field_many2one_tests.js
+++ b/addons/web/static/tests/fields/relational_fields/field_many2one_tests.js
@@ -356,7 +356,7 @@ QUnit.module('fields', {}, function () {
                 res_id: 1,
             });
 
-            assert.strictEqual($('a.o_form_uri').html(), 'aaa<br>Street<br>City ZIP',
+            assert.strictEqual(form.$('a.o_form_uri').html(), '<span>aaa</span><br><span>Street</span><br><span>City ZIP</span>',
                 "input should have a multi-line content in readonly due to show_address");
             await testUtils.form.clickEdit(form);
             assert.containsOnce(form, 'button.o_external_button:visible',