From e9fd752b344af0d38ddf4e81a9ab9cd7722d6734 Mon Sep 17 00:00:00 2001 From: "Divyesh Makwana (Open ERP)" Date: Thu, 27 Sep 2012 14:05:35 +0530 Subject: [PATCH] [FIX] stock : Traceback when click on Return Shipment Wizard. bzr revid: mdi@tinyerp.com-20120927083535-f5trwbj0o7hlvbxf --- addons/stock/wizard/stock_return_picking.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/stock/wizard/stock_return_picking.py b/addons/stock/wizard/stock_return_picking.py index d0494432bd2..abe1754a49e 100644 --- a/addons/stock/wizard/stock_return_picking.py +++ b/addons/stock/wizard/stock_return_picking.py @@ -100,8 +100,8 @@ class stock_return_picking(osv.osv_memory): valid_lines = 0 return_history = self.get_return_history(cr, uid, record_id, context) for m in pick.move_lines: - if m.product_qty * m.product_uom.factor > return_history.get(m.id, 0): - valid_lines += 1 + if m.state == 'done' and m.product_qty * m.product_uom.factor > return_history.get(m.id, 0): + valid_lines += 1 if not valid_lines: raise osv.except_osv(_('Warning!'), _("No products to return (only lines in Done state and not fully returned yet can be returned)!")) return res