From e9dfb08021351aef187ca976b1ff409b8b8a3c95 Mon Sep 17 00:00:00 2001
From: "Rodopho Cammarosano de Lima (rcdl)" <rcdl@odoo.com>
Date: Tue, 25 Oct 2022 18:17:59 +0000
Subject: [PATCH] [IMP] web_editor: clean buttons from icon toolbar

Some buttons/actions were unsuitable for icons (were made for images).
fa-icon for toggle icon spin was misleading ("refresh").

task#2737569

closes odoo/odoo#104163

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
---
 addons/web_editor/static/src/js/wysiwyg/wysiwyg.js | 8 ++++++++
 addons/web_editor/static/src/xml/editor.xml        | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js b/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js
index 64f2de6e444..289ed4e19f3 100644
--- a/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js
+++ b/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js
@@ -1874,6 +1874,14 @@ const Wysiwyg = Widget.extend({
         // Some icons are relevant for icons, that aren't for other media.
         this.toolbar.$el.find('#colorInputButtonGroup, #create-link').toggleClass('d-none', isInMedia && !$target.is('.fa'));
         this.toolbar.$el.find('.only_fa').toggleClass('d-none', !$target.is('.fa'));
+        // Hide unsuitable buttons for icon 
+        if ($target.is('.fa')) {
+            this.toolbar.$el.find([
+                '#image-shape',
+                '#image-width',
+                '#image-edit',
+            ].join(',')).toggleClass('d-none', true);
+        }
         // Hide the create-link button if the selection spans several blocks.
         selection = this.odooEditor.document.getSelection();
         const range = selection && selection.rangeCount && selection.getRangeAt(0);
diff --git a/addons/web_editor/static/src/xml/editor.xml b/addons/web_editor/static/src/xml/editor.xml
index 4acbf241c7d..c877510ccd8 100644
--- a/addons/web_editor/static/src/xml/editor.xml
+++ b/addons/web_editor/static/src/xml/editor.xml
@@ -211,7 +211,7 @@
             </div>
 
             <div class="btn-group only_fa">
-                <div id="fa-spin" title="Toggle icon spin" class="editor-ignore btn fa fa-refresh"></div>
+                <div id="fa-spin" title="Toggle icon spin" class="editor-ignore btn fa fa-play"></div>
             </div>
         </div>
     </t>