From e9d20e01bc09f768f004ed4c986f9483d9d6e647 Mon Sep 17 00:00:00 2001 From: "mra (Open ERP)" Date: Mon, 29 Dec 2008 11:10:49 +0530 Subject: [PATCH] base module quality bzr revid: mra@tinyerp.com-20081229054049-ht4jqvwjt8047plb --- addons/base_module_quality/base_module_quality.py | 10 +++++----- addons/base_module_quality/method_test/method_test.py | 2 +- addons/base_module_quality/pylint_test/pylint_test.py | 2 +- addons/base_module_quality/speed_test/speed_test.py | 2 +- .../base_module_quality/wizard/module_quality_check.py | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/addons/base_module_quality/base_module_quality.py b/addons/base_module_quality/base_module_quality.py index 101043b498c..78e2b903495 100644 --- a/addons/base_module_quality/base_module_quality.py +++ b/addons/base_module_quality/base_module_quality.py @@ -100,10 +100,10 @@ class abstract_quality_check(object): detail = "" detail += "\n===Method Test===\n" detail += ('{| border="1" cellspacing="0" cellpadding="5" align="left" \n! %-40s \n! %-16s \n! %-20s \n! %-16s ') % (header[0].ljust(40), header[1].ljust(16), header[2].ljust(20), header[3].ljust(16)) - for res in data_list[1][0]: - detail += ('\n|-\n| %s \n| %s \n| %s \n| %s ') % (res, data_list[1][0][res][0], data_list[1][0][res][1], data_list[1][0][res][2]) - res_format['summary'] = [data_list[0][0]] - res_format['detail'] = [detail + '\n|}'] + for res in data_list[1]: + detail += ('\n|-\n| %s \n| %s \n| %s \n| %s ') % (res, data_list[1][res][0], data_list[1][res][1], data_list[1][res][2]) + res_format['summary'] = data_list[0] + res_format['detail'] = detail + '\n|}' elif test=='pylint': res_format['summary'] = data_list[0] res_format['detail'] = data_list[1] @@ -114,7 +114,7 @@ class abstract_quality_check(object): for data in data_list[1]: detail += ('\n|-\n| %s \n| %s \n| %s \n| %s \n| %s \n| %s ') % (data[0], data[1], data[2], data[3], data[4], data[5]) res_format['summary'] = data_list[0] - res_format['detail'] = [detail + '\n|}\n'] + res_format['detail'] = detail + '\n|}\n' return res_format diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index b2015723dcb..09dbdb3f30a 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -82,7 +82,7 @@ class quality_test(base_module_quality.abstract_quality_check): This test checks if the module classes are raising exception when calling basic methods or no. """ + "Score: " + str(self.score) + "/10\n" - self.result = self.format_table(test='method', header=header_list, data_list=[[summary],[result]]) + self.result = self.format_table(test='method', header=header_list, data_list=[summary,result]) return None diff --git a/addons/base_module_quality/pylint_test/pylint_test.py b/addons/base_module_quality/pylint_test/pylint_test.py index 5bf240346d1..d448cf1595a 100644 --- a/addons/base_module_quality/pylint_test/pylint_test.py +++ b/addons/base_module_quality/pylint_test/pylint_test.py @@ -81,7 +81,7 @@ class quality_test(base_module_quality.abstract_quality_check): This test checks if the module satisfy the current coding standard used by OpenERP. """ + "Score: " + str(self.score) + "/10\n" - self.result = self.format_table(test='pylint', data_list=[[summary],[detail]]) + self.result = self.format_table(test='pylint', data_list=[summary,detail]) return None diff --git a/addons/base_module_quality/speed_test/speed_test.py b/addons/base_module_quality/speed_test/speed_test.py index 5a9176e4946..5200bd2b4bd 100644 --- a/addons/base_module_quality/speed_test/speed_test.py +++ b/addons/base_module_quality/speed_test/speed_test.py @@ -102,7 +102,7 @@ class quality_test(base_module_quality.abstract_quality_check): This test checks the speed of the module. """+ "Score: " + str(self.score) + "/10\n" - self.result = self.format_table(test='speed', header=header_list, data_list=[[summary],list1]) + self.result = self.format_table(test='speed', header=header_list, data_list=[summary,list1]) return None # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: diff --git a/addons/base_module_quality/wizard/module_quality_check.py b/addons/base_module_quality/wizard/module_quality_check.py index 48a04f8f921..cda3a92dcbf 100644 --- a/addons/base_module_quality/wizard/module_quality_check.py +++ b/addons/base_module_quality/wizard/module_quality_check.py @@ -81,8 +81,8 @@ class wiz_quality_check(osv.osv_memory): val.run_test(cr, uid, str(module_path)) else: val.result += "The module has to be installed before running this test." - string_ret += val.result['summary'][0] - string_detail += val.result['detail'][0] + string_ret += val.result['summary'] + string_detail += val.result['detail'] self.string_detail = string_detail return string_ret