From e96a29d70c5cb4d9bb55ea3ae339a9098e59c821 Mon Sep 17 00:00:00 2001
From: JF Aubert <ajf@odoo.com>
Date: Tue, 4 Oct 2022 12:08:52 +0000
Subject: [PATCH] [FIX] stock,stock_barcode: adjust picking type ui

Make operation type a title.
Change description of some fields in General tab.

closes odoo/odoo#102703

Task: 3004014
X-original-commit: 2cc799edc58f96009c0323e0871e077339967557
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
---
 addons/stock/models/stock_picking.py            |  2 +-
 addons/stock/views/stock_picking_type_views.xml | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/addons/stock/models/stock_picking.py b/addons/stock/models/stock_picking.py
index b5e3aa7283f..0387dfb7e80 100644
--- a/addons/stock/models/stock_picking.py
+++ b/addons/stock/models/stock_picking.py
@@ -33,7 +33,7 @@ class PickingType(models.Model):
     sequence_id = fields.Many2one(
         'ir.sequence', 'Reference Sequence',
         check_company=True, copy=False)
-    sequence_code = fields.Char('Code', required=True)
+    sequence_code = fields.Char('Sequence Prefix', required=True)
     default_location_src_id = fields.Many2one(
         'stock.location', 'Default Source Location',
         check_company=True,
diff --git a/addons/stock/views/stock_picking_type_views.xml b/addons/stock/views/stock_picking_type_views.xml
index 96e9df7236c..bea8dabdc59 100644
--- a/addons/stock/views/stock_picking_type_views.xml
+++ b/addons/stock/views/stock_picking_type_views.xml
@@ -77,12 +77,14 @@
             <form string="Operation Types">
                 <sheet>
                     <widget name="web_ribbon" title="Archived" bg_color="bg-danger" attrs="{'invisible': [('active', '=', True)]}"/>
+                    <label for="name"/>
+                    <h1><field name="name" placeholder="e.g. Receptions"/></h1>
                     <group name="first">
                         <group>
+                            <field name="code"/>
                             <field name="active" invisible="1"/>
                             <field name="company_id" invisible="1"/>
                             <field name="hide_reservation_method" invisible="1"/>
-                            <field name="name"/>
                             <field name="sequence_id" groups="base.group_no_one"/>
                             <field name="sequence_code"/>
                             <field name="warehouse_id" groups="stock.group_stock_multi_warehouses" force_save="1"/>
@@ -95,18 +97,17 @@
                             </div>
                         </group>
                         <group>
-                            <field name="code"/>
                             <field name="company_id" groups="base.group_multi_company" options="{'no_create': True}"/>
-                            <field attrs='{"invisible": [("code", "not in", ["incoming", "outgoing", "internal"])]}' name="return_picking_type_id"/>
+                            <field attrs='{"invisible": [("code", "not in", ["incoming", "outgoing", "internal"])]}' name="return_picking_type_id" string="Returns Type"/>
                             <field name="create_backorder"/>
                             <field name="show_operations"/>
                             <field name="show_reserved" attrs="{'invisible': [('code', '!=', 'incoming')]}"/>
                         </group>
                     </group>
                     <group name="second">
-                        <group attrs='{"invisible": [("code", "not in", ["incoming", "outgoing", "internal"])]}' string="Traceability" groups="stock.group_production_lot" name="stock_picking_type_lot">
-                            <field name="use_create_lots"/>
-                            <field name="use_existing_lots"/>
+                        <group attrs='{"invisible": [("code", "not in", ["incoming", "outgoing", "internal"])]}' string="Lots/Serial Numbers" groups="stock.group_production_lot" name="stock_picking_type_lot">
+                            <field name="use_create_lots" string="Create New"/>
+                            <field name="use_existing_lots" string="Use Existing ones"/>
                         </group>
                         <group attrs='{"invisible": [("code", "not in", ["incoming", "outgoing", "internal"])]}' string="Packages" groups="stock.group_tracking_lot">
                             <field name="show_entire_packs"/>