From e8a4f4dce81ed984bebc86ebda35029b9e7a0628 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Theys?= <seb@odoo.com>
Date: Mon, 13 Mar 2023 15:18:39 +0000
Subject: [PATCH] [IMP] bus, mail: make test data more consistent
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In preparation of discuss refactoring.

closes odoo/odoo#115047

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
---
 .../tests/helpers/model_definitions_setup.js    |  2 +-
 .../tests/helpers/view_definitions_setup.js     |  8 --------
 .../tests/helpers/model_definitions_setup.js    |  3 ++-
 .../tests/helpers/view_definitions_setup.js     | 17 +++++++++++++++++
 4 files changed, 20 insertions(+), 10 deletions(-)
 create mode 100644 addons/mail/static/tests/helpers/view_definitions_setup.js

diff --git a/addons/bus/static/tests/helpers/model_definitions_setup.js b/addons/bus/static/tests/helpers/model_definitions_setup.js
index 58e4dd26767..5b29be2dabb 100644
--- a/addons/bus/static/tests/helpers/model_definitions_setup.js
+++ b/addons/bus/static/tests/helpers/model_definitions_setup.js
@@ -39,5 +39,5 @@ insertRecords('res.users', [
 insertRecords('res.partner', [
     { active: false, display_name: "Public user", id: TEST_USER_IDS.publicPartnerId, is_public: true },
     { display_name: "Your Company, Mitchell Admin", id: TEST_USER_IDS.currentPartnerId, name: "Mitchell Admin", },
-    { active: false, display_name: "OdooBot", id: TEST_USER_IDS.partnerRootId, name: "OdooBot" },
+    { active: false, display_name: "OdooBot", id: TEST_USER_IDS.partnerRootId, im_status: "bot", name: "OdooBot" },
 ]);
diff --git a/addons/bus/static/tests/helpers/view_definitions_setup.js b/addons/bus/static/tests/helpers/view_definitions_setup.js
index 716f3fdda82..59c3086ef9c 100644
--- a/addons/bus/static/tests/helpers/view_definitions_setup.js
+++ b/addons/bus/static/tests/helpers/view_definitions_setup.js
@@ -28,11 +28,3 @@ formArchsRegistry.add(
         </div>
     </form>`
 );
-formArchsRegistry.add(
-    'res.fake',
-    `<form>
-        <div class="oe_chatter">
-            <field name="message_ids"/>
-        </div>
-    </form>`
-);
diff --git a/addons/mail/static/tests/helpers/model_definitions_setup.js b/addons/mail/static/tests/helpers/model_definitions_setup.js
index 8043f78cec6..ffa14f68168 100644
--- a/addons/mail/static/tests/helpers/model_definitions_setup.js
+++ b/addons/mail/static/tests/helpers/model_definitions_setup.js
@@ -22,6 +22,7 @@ addModelNamesToFetch([
     "mail.guest",
     "mail.link.preview",
     "mail.message",
+    "mail.message.reaction",
     "mail.message.subtype",
     "mail.notification",
     "mail.shortcode",
@@ -34,6 +35,7 @@ addModelNamesToFetch([
 addFakeModel("res.fake", {
     message_ids: { string: "Messages", type: "one2many", relation: "mail.message" },
     activity_ids: { string: "Activities", type: "one2many", relation: "mail.activity" },
+    message_follower_ids: { string: "Followers", type: "char" },
     email_cc: { type: "char" },
     partner_ids: { relation: "res.partner", string: "Related partners", type: "one2many" },
 });
@@ -85,7 +87,6 @@ insertModelFields("mail.message", {
     },
     is_discussion: { string: "Discussion", type: "boolean" },
     is_note: { string: "Discussion", type: "boolean" },
-    is_notification: { string: "Note", type: "boolean" },
     needaction_partner_ids: {
         relation: "res.partner",
         string: "Partners with Need Action",
diff --git a/addons/mail/static/tests/helpers/view_definitions_setup.js b/addons/mail/static/tests/helpers/view_definitions_setup.js
new file mode 100644
index 00000000000..a7b760af9a2
--- /dev/null
+++ b/addons/mail/static/tests/helpers/view_definitions_setup.js
@@ -0,0 +1,17 @@
+/* @odoo-module */
+
+import { registry } from "@web/core/registry";
+
+registry
+    .category("bus.view.archs")
+    .category("form")
+    .add(
+        "res.fake",
+        `<form>
+            <sheet/>
+            <div class="oe_chatter">
+                <field name="message_ids"/>
+                <field name="message_follower_ids"/>
+            </div>
+        </form>`
+    );