From e70abb63d49bec3cf1e1ca02f0557b7db9d64307 Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Fri, 26 Apr 2019 13:17:30 +0000 Subject: [PATCH] [REF] addons: avoid using NewId --- addons/http_routing/models/ir_http.py | 2 +- addons/website_event_track/models/event_track.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/http_routing/models/ir_http.py b/addons/http_routing/models/ir_http.py index 12c81e9d620..0e2ecc1e33f 100644 --- a/addons/http_routing/models/ir_http.py +++ b/addons/http_routing/models/ir_http.py @@ -85,7 +85,7 @@ def slugify(s, max_length=None, path=False): def slug(value): if isinstance(value, models.BaseModel): - if isinstance(value.id, models.NewId): + if not value.id: raise ValueError("Cannot slug non-existent record %s" % value) # [(id, name)] = value.name_get() identifier, name = value.id, value.display_name diff --git a/addons/website_event_track/models/event_track.py b/addons/website_event_track/models/event_track.py index 6be7d86e75c..40c11351603 100644 --- a/addons/website_event_track/models/event_track.py +++ b/addons/website_event_track/models/event_track.py @@ -95,7 +95,7 @@ class Track(models.Model): def _compute_website_url(self): super(Track, self)._compute_website_url() for track in self: - if not isinstance(track.id, models.NewId): + if track.id: track.website_url = '/event/%s/track/%s' % (slug(track.event_id), slug(track)) @api.onchange('partner_id')