From e56a095f16b8f0f76a1f675fb074bd3fb10d347a Mon Sep 17 00:00:00 2001
From: Mathieu Duckerts-Antoine <dam@odoo.com>
Date: Thu, 10 Sep 2020 10:02:51 +0000
Subject: [PATCH] [FIX] *: disable linking on some graph views

For the graph views based on reporting models (e.g sale.report), click
on a group in the chart redirects the user to an "empty" list view. Here
we use the attribute disable_linking to avoid that redirection for those
views.

Task ID: 2336960

closes odoo/odoo#57622

X-original-commit: 0b0ae92b6bdac25843ba24d767dbcab3b75703e5
Related: odoo/enterprise#13192
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 addons/account/report/account_invoice_report_view.xml           | 2 +-
 addons/crm/report/crm_activity_report_views.xml                 | 2 +-
 addons/hr_timesheet/report/project_report_view.xml              | 2 +-
 addons/im_livechat/report/im_livechat_report_channel_views.xml  | 2 +-
 addons/im_livechat/report/im_livechat_report_operator_views.xml | 2 +-
 addons/mass_mailing/report/mailing_trace_report_views.xml       | 2 +-
 addons/membership/report/report_membership_views.xml            | 2 +-
 addons/point_of_sale/views/pos_order_report_view.xml            | 2 +-
 addons/project/report/project_report_views.xml                  | 2 +-
 addons/purchase/report/purchase_report_views.xml                | 2 +-
 addons/sale/report/sale_report_views.xml                        | 2 +-
 .../report/project_profitability_report_analysis_views.xml      | 2 +-
 addons/website_sale/views/sale_report_views.xml                 | 2 +-
 addons/website_sale_slides/report/sale_report_views.xml         | 2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/addons/account/report/account_invoice_report_view.xml b/addons/account/report/account_invoice_report_view.xml
index ee9ee109b7c..9bfaaa19720 100644
--- a/addons/account/report/account_invoice_report_view.xml
+++ b/addons/account/report/account_invoice_report_view.xml
@@ -17,7 +17,7 @@
          <field name="name">account.invoice.report.graph</field>
          <field name="model">account.invoice.report</field>
          <field name="arch" type="xml">
-             <graph string="Invoices Analysis" type="line" sample="1">
+             <graph string="Invoices Analysis" type="line" sample="1" disable_linking="1">
                  <field name="product_categ_id"/>
                  <field name="price_subtotal" type="measure"/>
              </graph>
diff --git a/addons/crm/report/crm_activity_report_views.xml b/addons/crm/report/crm_activity_report_views.xml
index 72bba532528..987b865fe7b 100644
--- a/addons/crm/report/crm_activity_report_views.xml
+++ b/addons/crm/report/crm_activity_report_views.xml
@@ -5,7 +5,7 @@
             <field name="name">crm.activity.report.graph</field>
             <field name="model">crm.activity.report</field>
             <field name="arch" type="xml">
-                <graph string="Activities Analysis" stacked="True" sample="1">
+                <graph string="Activities Analysis" stacked="True" sample="1" disable_linking="1">
                     <field name="mail_activity_type_id" type="col"/>
                     <field name="date" interval="month" type="row"/>
                 </graph>
diff --git a/addons/hr_timesheet/report/project_report_view.xml b/addons/hr_timesheet/report/project_report_view.xml
index 54529f66e39..d62fb501592 100644
--- a/addons/hr_timesheet/report/project_report_view.xml
+++ b/addons/hr_timesheet/report/project_report_view.xml
@@ -6,7 +6,7 @@
             <field name="model">report.project.task.user</field>
             <field name="inherit_id" ref="project.view_task_project_user_graph" />
             <field name="arch" type="xml">
-                <graph string="Tasks Analysis" type="bar" sample="1">
+                <graph string="Tasks Analysis" type="bar" sample="1" disable_linking="1">
                     <field name="project_id" position="after">
                         <field name="hours_planned" type="measure"/>
                         <field name="remaining_hours" type="measure"/>
diff --git a/addons/im_livechat/report/im_livechat_report_channel_views.xml b/addons/im_livechat/report/im_livechat_report_channel_views.xml
index d34b433380f..1de3ca5c327 100644
--- a/addons/im_livechat/report/im_livechat_report_channel_views.xml
+++ b/addons/im_livechat/report/im_livechat_report_channel_views.xml
@@ -18,7 +18,7 @@
             <field name="name">im_livechat.report.channel.graph</field>
             <field name="model">im_livechat.report.channel</field>
             <field name="arch" type="xml">
-                <graph string="Livechat Support Statistics" sample="1">
+                <graph string="Livechat Support Statistics" sample="1" disable_linking="1">
                     <field name="technical_name"/>
                     <field name="nbr_message" type="measure"/>
                 </graph>
diff --git a/addons/im_livechat/report/im_livechat_report_operator_views.xml b/addons/im_livechat/report/im_livechat_report_operator_views.xml
index 64163f5fef4..e2059fed6bc 100644
--- a/addons/im_livechat/report/im_livechat_report_operator_views.xml
+++ b/addons/im_livechat/report/im_livechat_report_operator_views.xml
@@ -18,7 +18,7 @@
             <field name="name">im_livechat.report.operator.graph</field>
             <field name="model">im_livechat.report.operator</field>
             <field name="arch" type="xml">
-                <graph string="Livechat Support Statistics" sample="1">
+                <graph string="Livechat Support Statistics" sample="1" disable_linking="1">
                     <field name="partner_id"/>
                     <field name="nbr_channel" type="measure"/>
                 </graph>
diff --git a/addons/mass_mailing/report/mailing_trace_report_views.xml b/addons/mass_mailing/report/mailing_trace_report_views.xml
index 8472251f765..8b309b7936e 100644
--- a/addons/mass_mailing/report/mailing_trace_report_views.xml
+++ b/addons/mass_mailing/report/mailing_trace_report_views.xml
@@ -20,7 +20,7 @@
             <field name="name">mailing.trace.report.view.graph</field>
             <field name="model">mailing.trace.report</field>
             <field name="arch" type="xml">
-                <graph string="Mass Mailing Statistics" sample="1">
+                <graph string="Mass Mailing Statistics" sample="1" disable_linking="1">
                     <field name="campaign"/>
                     <field name="sent" type="measure"/>
                 </graph>
diff --git a/addons/membership/report/report_membership_views.xml b/addons/membership/report/report_membership_views.xml
index 15f002e8917..07c1498561d 100644
--- a/addons/membership/report/report_membership_views.xml
+++ b/addons/membership/report/report_membership_views.xml
@@ -50,7 +50,7 @@
             <field name="name">report.membership.graph1</field>
             <field name="model">report.membership</field>
             <field name="arch" type="xml">
-                <graph string="Membership" sample="1">
+                <graph string="Membership" sample="1" disable_linking="1">
                     <field name="membership_id" type="row"/>
                     <field name="start_date" interval="month" type="col"/>
                     <field name="quantity" type="measure"/>
diff --git a/addons/point_of_sale/views/pos_order_report_view.xml b/addons/point_of_sale/views/pos_order_report_view.xml
index 14a78447c5b..6e708811086 100644
--- a/addons/point_of_sale/views/pos_order_report_view.xml
+++ b/addons/point_of_sale/views/pos_order_report_view.xml
@@ -18,7 +18,7 @@
             <field name="name">report.pos.order.graph</field>
             <field name="model">report.pos.order</field>
             <field name="arch" type="xml">
-                <graph string="Point of Sale Analysis" sample="1">
+                <graph string="Point of Sale Analysis" sample="1" disable_linking="1">
                     <field name="product_categ_id" type="row"/>
                     <field name="price_total" type="measure"/>
                 </graph>
diff --git a/addons/project/report/project_report_views.xml b/addons/project/report/project_report_views.xml
index 7e5e0520e23..e4aedce03a9 100644
--- a/addons/project/report/project_report_views.xml
+++ b/addons/project/report/project_report_views.xml
@@ -15,7 +15,7 @@
             <field name="name">report.project.task.user.graph</field>
             <field name="model">report.project.task.user</field>
             <field name="arch" type="xml">
-                <graph string="Tasks Analysis" type="bar" sample="1">
+                <graph string="Tasks Analysis" type="bar" sample="1" disable_linking="1">
                      <field name="project_id" type="row"/>
                      <field name="user_id" type="col"/>
                      <field name="nbr" type="measure"/>
diff --git a/addons/purchase/report/purchase_report_views.xml b/addons/purchase/report/purchase_report_views.xml
index e03d2c7ee15..7ebcaf05718 100644
--- a/addons/purchase/report/purchase_report_views.xml
+++ b/addons/purchase/report/purchase_report_views.xml
@@ -16,7 +16,7 @@
             <field name="name">product.month.graph</field>
             <field name="model">purchase.report</field>
             <field name="arch" type="xml">
-                <graph string="Purchase Orders Statistics" type="line" sample="1">
+                <graph string="Purchase Orders Statistics" type="line" sample="1" disable_linking="1">
                     <field name="date_approve" interval="day" type="col"/>
                     <field name="untaxed_total" type="measure"/>
                 </graph>
diff --git a/addons/sale/report/sale_report_views.xml b/addons/sale/report/sale_report_views.xml
index 88f39ad8bb4..32fa2d9ea82 100644
--- a/addons/sale/report/sale_report_views.xml
+++ b/addons/sale/report/sale_report_views.xml
@@ -17,7 +17,7 @@
          <field name="name">sale.report.graph</field>
          <field name="model">sale.report</field>
          <field name="arch" type="xml">
-             <graph string="Sales Analysis" type="line" sample="1">
+             <graph string="Sales Analysis" type="line" sample="1" disable_linking="1">
                  <field name="date" type="row" interval="day"/>
                  <field name="price_subtotal" type="measure"/>
              </graph>
diff --git a/addons/sale_timesheet/report/project_profitability_report_analysis_views.xml b/addons/sale_timesheet/report/project_profitability_report_analysis_views.xml
index ae8eb2b6ced..ff400b632b3 100644
--- a/addons/sale_timesheet/report/project_profitability_report_analysis_views.xml
+++ b/addons/sale_timesheet/report/project_profitability_report_analysis_views.xml
@@ -18,7 +18,7 @@
         <field name="name">project.profitability.report.graph</field>
         <field name="model">project.profitability.report</field>
         <field name="arch" type="xml">
-            <graph string="Profitability Analysis" type="bar" sample="1">
+            <graph string="Profitability Analysis" type="bar" sample="1" disable_linking="1">
                 <field name="project_id" type="row"/>
                 <field name="product_id" type="col"/>
                 <field name="amount_untaxed_to_invoice" type="measure"/>
diff --git a/addons/website_sale/views/sale_report_views.xml b/addons/website_sale/views/sale_report_views.xml
index af889558ea1..d17325b9fa4 100644
--- a/addons/website_sale/views/sale_report_views.xml
+++ b/addons/website_sale/views/sale_report_views.xml
@@ -44,7 +44,7 @@
         <field name="name">sale.report.view.graph.website</field>
         <field name="model">sale.report</field>
         <field name="arch" type="xml">
-            <graph string="Sale Report" type="bar" sample="1">
+            <graph string="Sale Report" type="bar" sample="1" disable_linking="1">
                 <field name="date"/>
                 <field name="price_subtotal" type='measure'/>
             </graph>
diff --git a/addons/website_sale_slides/report/sale_report_views.xml b/addons/website_sale_slides/report/sale_report_views.xml
index 452c78a3f78..31d8a382cad 100644
--- a/addons/website_sale_slides/report/sale_report_views.xml
+++ b/addons/website_sale_slides/report/sale_report_views.xml
@@ -4,7 +4,7 @@
          <field name="name">sale.report.view.graph.slides</field>
          <field name="model">sale.report</field>
          <field name="arch" type="xml">
-             <graph string="eLearning Sales Analysis" type="line" sample="1">
+             <graph string="eLearning Sales Analysis" type="line" sample="1" disable_linking="1">
                  <field name="date" type="row" interval="day"/>
                  <field name="price_subtotal" type="measure"/>
              </graph>