From e4c3f778ccb22fa1925398482b07a111e4a7aab4 Mon Sep 17 00:00:00 2001 From: Samuel Degueldre Date: Mon, 4 May 2020 07:23:20 +0000 Subject: [PATCH] [FIX] website: don't interpolate null values for css properties In 29f02a37f042 we bumped the verion of libsass that we use. One breaking change introduced by the new version is that if a css variable is interpolated to the empty string, it is still emited in the compiled css [1] This commit fixes that by explicitly omitting null values from the map before looping over it. [1]: https://sass-lang.com/documentation/breaking-changes/css-vars task-2248360 closes odoo/odoo#50668 X-original-commit: 6faf327706169bbe31e188a42805085b95b78052 Signed-off-by: Quentin Smetz (qsm) --- addons/website/static/src/scss/website.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website/static/src/scss/website.scss b/addons/website/static/src/scss/website.scss index eb0a3be0423..363528e30a5 100644 --- a/addons/website/static/src/scss/website.scss +++ b/addons/website/static/src/scss/website.scss @@ -37,7 +37,7 @@ $-font-numbers: ( // 3) The values in the $colors map are also printed by Bootstrap. // 4) The Odoo values map, $o-website-values, must be printed. - @each $key, $value in $o-website-values { + @each $key, $value in o-map-omit($o-website-values) { --#{$key}: #{$value}; }