From e4a93776b37671208de1d38b8d87cbf7b63cc4d4 Mon Sep 17 00:00:00 2001 From: Damien Bouvy Date: Wed, 5 Aug 2015 11:41:53 +0200 Subject: [PATCH] [FIX] payment_ogone: s2s feedback controller does not need authentication and function name error no longer prevents tx validation --- addons/payment_ogone/controllers/main.py | 2 +- addons/payment_ogone/models/ogone.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/addons/payment_ogone/controllers/main.py b/addons/payment_ogone/controllers/main.py index 6443e85f426..451c3683aaa 100644 --- a/addons/payment_ogone/controllers/main.py +++ b/addons/payment_ogone/controllers/main.py @@ -44,7 +44,7 @@ class OgoneController(http.Controller): acquirer.s2s_process(post) return werkzeug.utils.redirect(post.get('return_url', '/')) - @http.route(['/payment/ogone/s2s/feedback']) + @http.route(['/payment/ogone/s2s/feedback'], auth='none') def feedback(self, **kwargs): cr, uid, context = request.cr, SUPERUSER_ID, request.context payment = request.registry.get('payment.transaction') diff --git a/addons/payment_ogone/models/ogone.py b/addons/payment_ogone/models/ogone.py index aafe2e1f438..40bd0e2a974 100644 --- a/addons/payment_ogone/models/ogone.py +++ b/addons/payment_ogone/models/ogone.py @@ -373,11 +373,12 @@ class PaymentTxOgone(osv.Model): def _ogone_s2s_validate(self, tx): tree = self._ogone_s2s_get_tx_status(tx) - return self.ogone_s2s_validate(tx, tree) + return self._ogone_s2s_validate_tree(tx, tree) def _ogone_s2s_validate_tree(self, tx, tree, tries=2): if tx.state not in ('draft', 'pending'): - return True # already validated + _logger.info('Ogone: trying to validate an already validated tx (ref %s)', tx.reference) + return True status = int(tree.get('STATUS', '0')) if status in self._ogone_valid_tx_status: