From 50960407e600c5e189bf55dd43924b375f42aeb3 Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@mra-laptop>
Date: Fri, 2 Jul 2010 10:46:21 +0530
Subject: [PATCH 1/4] [FIX] account: action number method creating sequnce for
 the invoice

bzr revid: mra@mra-laptop-20100702051621-4ckg06v9vhi7vihv
---
 addons/account/invoice.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/account/invoice.py b/addons/account/invoice.py
index 261ec4c3c0d..4e64507b496 100644
--- a/addons/account/invoice.py
+++ b/addons/account/invoice.py
@@ -790,7 +790,7 @@ class account_invoice(osv.osv):
 
             # one move line per tax line
             iml += ait_obj.move_line_get(cr, uid, inv.id)
-            
+
             entry_type=''
             if inv.type in ('in_invoice', 'in_refund'):
                 ref = inv.reference
@@ -922,7 +922,7 @@ class account_invoice(osv.osv):
             if not number:
                 if obj_inv.journal_id.invoice_sequence_id:
                     sid = obj_inv.journal_id.invoice_sequence_id.id
-                    number = self.pool.get('ir.sequence').get_id(cr, uid, sid, 'id=%s', {'fiscalyear_id': obj_inv.period_id.fiscalyear_id.id})
+                    number = self.pool.get('ir.sequence').get_id(cr, uid, sid, 'id', {'fiscalyear_id': obj_inv.period_id.fiscalyear_id.id})
                 else:
                     number = self.pool.get('ir.sequence').get(cr, uid,
                             'account.invoice.' + invtype)
@@ -1028,7 +1028,7 @@ class account_invoice(osv.osv):
 
     def refund(self, cr, uid, ids, date=None, period_id=None, description=None):
         invoices = self.read(cr, uid, ids, ['name', 'type', 'number', 'reference', 'comment', 'date_due', 'partner_id', 'address_contact_id', 'address_invoice_id', 'partner_contact', 'partner_insite', 'partner_ref', 'payment_term', 'account_id', 'currency_id', 'invoice_line', 'tax_line', 'journal_id'])
-        
+
         new_ids = []
         for invoice in invoices:
             del invoice['id']

From c4aa8bc8a37af5ea820b5339e59940b476b787af Mon Sep 17 00:00:00 2001
From: Mantavya Gajjar <mga@tinyerp.com>
Date: Fri, 2 Jul 2010 11:12:29 +0530
Subject: [PATCH 2/4] [IMP]: improvement in hr_payroll, payslip view

bzr revid: mga@tinyerp.com-20100702054229-3z91plsgvbm338wk
---
 addons/hr_payroll/hr_payroll_view.xml | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/addons/hr_payroll/hr_payroll_view.xml b/addons/hr_payroll/hr_payroll_view.xml
index 371963c67b6..de5c4435156 100644
--- a/addons/hr_payroll/hr_payroll_view.xml
+++ b/addons/hr_payroll/hr_payroll_view.xml
@@ -486,23 +486,8 @@
                             </group>
                         </page>
                         <page string="Accounting Details">
-                            <group col="2" colspan="3">
-                                <separator colspan="4" string="Accounting Informations"/>
-                                <field name="move_ids" colspan="2" nolabel="1" readonly="1">
-                                    <tree string="Accounting Vouchers">
-                                        <field name="sequence"/>
-                                        <field name="name"/>
-                                        <field name="move_id"/>
-                                    </tree>
-                                    <form string="Accounting Vouchers">
-                                        <field name="sequence"/>
-                                        <field name="name"/>
-                                        <field name="move_id"/>
-                                    </form>
-                                </field>
-                            </group>
                             <group col="2" colspan="1">
-                                <separator colspan="4" string="Other Informations"/>
+                                <separator colspan="2" string="Other Informations"/>
                                 <field name="paid" readonly="1"/>
                                 <field name="company_id"/>
                                 <field name="register_id"/>
@@ -512,12 +497,6 @@
                             <separator colspan="4" string="Description"/>
                             <field name="note" colspan="4" nolabel="1"/>
                         </page>
-                        <page string="Account Lines">
-                            <field name="move_line_ids" colspan="4" nolabel="1"/>
-                        </page>
-                        <page string="Payment Lines">
-                            <field name="move_payment_ids" colspan="4" nolabel="1"/>
-                        </page>
                     </notebook>
                     <group col="10" colspan="4">
                         <field name="state"/>

From 047be686745c2903a886a3417584640a076ce7a6 Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@mra-laptop>
Date: Fri, 2 Jul 2010 11:25:01 +0530
Subject: [PATCH 3/4] [FIX] account: valdating moves did not create analytic
 entries and small change in view

bzr revid: mra@mra-laptop-20100702055501-evpi2n97wnio5t19
---
 addons/account/account.py               | 11 ++++++-----
 addons/account/account_invoice_view.xml |  2 +-
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/addons/account/account.py b/addons/account/account.py
index 210ae5b3157..14e5bb26e34 100644
--- a/addons/account/account.py
+++ b/addons/account/account.py
@@ -1199,6 +1199,7 @@ class account_move(osv.osv):
     #
     # Validate a balanced move. If it is a centralised journal, create a move.
     #
+
     def validate(self, cr, uid, ids, context={}):
         if context and ('__last_update' in context):
             del context['__last_update']
@@ -1283,11 +1284,11 @@ class account_move(osv.osv):
                     'state': 'draft'
                 }, context, check=False)
                 ok = False
-            if ok:
-                list_ids = []
-                for tmp in move.line_id:
-                    list_ids.append(tmp.id)
-                self.pool.get('account.move.line').create_analytic_lines(cr, uid, list_ids, context)
+        if ok:
+            list_ids = []
+            for tmp in move.line_id:
+                list_ids.append(tmp.id)
+            self.pool.get('account.move.line').create_analytic_lines(cr, uid, list_ids, context)
         return ok
 account_move()
 
diff --git a/addons/account/account_invoice_view.xml b/addons/account/account_invoice_view.xml
index fc10c58cc8f..7394fc54b7e 100644
--- a/addons/account/account_invoice_view.xml
+++ b/addons/account/account_invoice_view.xml
@@ -205,7 +205,7 @@
                                     <button name="invoice_open" states="draft,proforma2" string="Validate" icon="terp-camera_test"/>
                                     <button name="%(action_account_invoice_pay)d" type='action' string='Pay Invoice' states='open' icon="gtk-ok"/>
                                     <button name="invoice_cancel" states="draft,proforma2,sale,open" string="Cancel" icon="terp-gtk-stop"/>
-                                    <button name="action_cancel_draft" states="cancel" string="Set to Draft" type="object" icon="stock_effects-object-colorize"/>
+                                    <button name="action_cancel_draft" states="cancel" string="Set to Draft" type="object" icon="terp-stock_effects-object-colorize"/>
                                     <button name="%(action_account_state_open)d" type='action' string='Re-Open' states='paid' icon="gtk-convert"/>
                                     <button name="%(action_account_invoice_refund)d" type='action' string='Credit Note' states='paid' icon="terp-dolar"/>
                                 </group>

From 0b385ca3092d02993964524df95a1ce95db1b083 Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@mra-laptop>
Date: Fri, 2 Jul 2010 12:23:52 +0530
Subject: [PATCH 4/4] [IMP] account: Add the warning if user try to create
 invoice without defining invoice sequence field on jounrnal

bzr revid: mra@mra-laptop-20100702065352-9w7x2x6p7p2ea3vj
---
 addons/account/invoice.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/addons/account/invoice.py b/addons/account/invoice.py
index 4e64507b496..13569987560 100644
--- a/addons/account/invoice.py
+++ b/addons/account/invoice.py
@@ -767,6 +767,8 @@ class account_invoice(osv.osv):
         cur_obj = self.pool.get('res.currency')
         context = {}
         for inv in self.browse(cr, uid, ids):
+            if not inv.journal_id.invoice_sequence_id:
+                raise osv.except_osv(_('Error !'), _('Please define invoice sequence on invoice journal'))
             if not inv.invoice_line:
                 raise osv.except_osv(_('No Invoice Lines !'), _('Please create some invoice lines.'))
             if inv.move_id: