From e3cd54bb1d1bb4eda4937504636e277edf5aa9c2 Mon Sep 17 00:00:00 2001 From: Pierre Masereel Date: Wed, 26 Apr 2017 11:11:04 +0200 Subject: [PATCH] [FIX] pylint: using variable before assignment Since last version (1.7) of pylint, new errors have been detected. Related to rev: https://github.com/odoo/odoo/commit/ecac88dcc074b81ede4925a75080e8d2b4975924 --- odoo/addons/base/res/res_lang.py | 2 +- odoo/osv/orm.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/odoo/addons/base/res/res_lang.py b/odoo/addons/base/res/res_lang.py index d1517a69764..6320f9d822d 100644 --- a/odoo/addons/base/res/res_lang.py +++ b/odoo/addons/base/res/res_lang.py @@ -259,7 +259,7 @@ class Lang(models.Model): if percent[-1] in 'eEfFgG': parts = formatted.split('.') - parts[0], _ = intersperse(parts[0], eval_lang_grouping, thousands_sep) + parts[0] = intersperse(parts[0], eval_lang_grouping, thousands_sep)[0] formatted = decimal_point.join(parts) diff --git a/odoo/osv/orm.py b/odoo/osv/orm.py index 2e383ad0d9e..6a815c9577a 100644 --- a/odoo/osv/orm.py +++ b/odoo/osv/orm.py @@ -118,13 +118,13 @@ def test_modifiers(what, expected): node = etree.fromstring(what) transfer_node_to_modifiers(node, modifiers) simplify_modifiers(modifiers) - json = json.dumps(modifiers) - assert json == expected, "%s != %s" % (json, expected) + dump = json.dumps(modifiers) + assert dump == expected, "%s != %s" % (dump, expected) elif isinstance(what, dict): transfer_field_to_modifiers(what, modifiers) simplify_modifiers(modifiers) - json = json.dumps(modifiers) - assert json == expected, "%s != %s" % (json, expected) + dump = json.dumps(modifiers) + assert dump == expected, "%s != %s" % (dump, expected) # To use this test: