From e2e23142e9aecabf4f1f5f18d9b73f8e56598c2b Mon Sep 17 00:00:00 2001 From: Olivier Dony Date: Tue, 6 Jun 2017 14:00:02 +0200 Subject: [PATCH] [FIX] base_import_module: make low-level method private The import_module() method does not need to be public, so let's mark it private. It's not called by anyone except import_zipfile(). After 76cd8d2558d2a1fc11681dbc4a134ba06fb698c0 it would fail anyway because addons_path would not be prepared by import_zipfile(). --- addons/base_import_module/models/ir_module.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/base_import_module/models/ir_module.py b/addons/base_import_module/models/ir_module.py index 9a703b40978..43eb8f08d6e 100644 --- a/addons/base_import_module/models/ir_module.py +++ b/addons/base_import_module/models/ir_module.py @@ -22,7 +22,7 @@ class IrModule(models.Model): imported = fields.Boolean(string="Imported Module") @api.multi - def import_module(self, module, path, force=False): + def _import_module(self, module, path, force=False): known_mods = self.search([]) known_mods_names = {m.name: m for m in known_mods} installed_mods = [m.name for m in known_mods if m.state == 'installed'] @@ -107,7 +107,7 @@ class IrModule(models.Model): try: # assert mod_name.startswith('theme_') path = opj(module_dir, mod_name) - self.import_module(mod_name, path, force=force) + self._import_module(mod_name, path, force=force) success.append(mod_name) except Exception as e: _logger.exception('Error while importing module')