From e2232c890946ca6b0f12fa2bb384da1e2f14933a Mon Sep 17 00:00:00 2001 From: Kevin Baptiste Date: Fri, 21 Oct 2022 07:25:39 +0000 Subject: [PATCH] [FIX] hr_attendance: use correct reference for kioskDelay A traceback would occur in some situations because of incorrect reference to `this.kioskDelay`. closes odoo/odoo#103753 X-original-commit: 5069c8fd1cee063827873de0f6c2d9fe938337a9 Signed-off-by: Kevin Baptiste --- addons/hr_attendance/static/src/js/greeting_message.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/addons/hr_attendance/static/src/js/greeting_message.js b/addons/hr_attendance/static/src/js/greeting_message.js index 7f5d0c45dc9..d23dbeaea82 100644 --- a/addons/hr_attendance/static/src/js/greeting_message.js +++ b/addons/hr_attendance/static/src/js/greeting_message.js @@ -164,6 +164,7 @@ var GreetingMessage = AbstractAction.extend({ clearTimeout(this.return_to_main_menu); } core.bus.off('barcode_scanned', this, this._onBarcodeScanned); + const kioskDelay = this.kioskDelay; this._rpc({ model: 'hr.employee', method: 'attendance_scan', @@ -174,13 +175,13 @@ var GreetingMessage = AbstractAction.extend({ self.do_action(result.action); } else if (result.warning) { self.displayNotification({ title: result.warning, type: 'danger' }); - if (this.kioskDelay > 0) { - setTimeout( function() { self.do_action(self.next_action, {clear_breadcrumbs: true}); }, this.kioskDelay); + if (kioskDelay > 0) { + setTimeout( function() { self.do_action(self.next_action, {clear_breadcrumbs: true}); }, kioskDelay); } } }, function () { - if (this.kioskDelay > 0) { - setTimeout( function() { self.do_action(self.next_action, {clear_breadcrumbs: true}); }, this.kioskDelay); + if (kioskDelay > 0) { + setTimeout( function() { self.do_action(self.next_action, {clear_breadcrumbs: true}); }, kioskDelay); } }); }