From e20c1b6eff1cef0e751eeebacc0bf17b85aa1283 Mon Sep 17 00:00:00 2001 From: Remi Rahir Date: Mon, 22 Jul 2019 08:53:49 +0000 Subject: [PATCH] [FIX] sms: fix some typos PURPOSE Followup of merge 4287481 . SPECIFICATIONS Notification type is now a selection -> use 'sms' instead of True; Fix typo in method renaming not correctly propagated to its view; LINKS Task 1922187 --- addons/sms/models/mail_message.py | 2 +- addons/sms/wizard/sms_cancel_views.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/sms/models/mail_message.py b/addons/sms/models/mail_message.py index ce76aa5349b..3f97b8abcb0 100644 --- a/addons/sms/models/mail_message.py +++ b/addons/sms/models/mail_message.py @@ -29,7 +29,7 @@ class MailMessage(models.Model): def _search_has_sms_error(self, operator, operand): if operator == '=' and operand: - return ['&', ('notification_ids.notification_status', '=', 'exception'), ('notification_ids.notification_type', '=', True)] + return ['&', ('notification_ids.notification_status', '=', 'exception'), ('notification_ids.notification_type', '=', 'sms')] raise NotImplementedError() def _format_mail_failures(self): diff --git a/addons/sms/wizard/sms_cancel_views.xml b/addons/sms/wizard/sms_cancel_views.xml index 74208e5fd4c..f672a80db64 100644 --- a/addons/sms/wizard/sms_cancel_views.xml +++ b/addons/sms/wizard/sms_cancel_views.xml @@ -10,7 +10,7 @@

If you want to re-send them, click Cancel now, then click on the notification and review them one by one by clicking on the red icon next to each message.