From e1566fa78f8d8d71d6be5fea5b045e9c78ef1d99 Mon Sep 17 00:00:00 2001 From: Florian Damhaut Date: Mon, 8 Nov 2021 09:14:34 +0000 Subject: [PATCH] [FIX] hr_holidays : no traceback when validate -> refuse -> to draft leave Current Behaviour : Go to Time off -> Approvals -> Time Off -> create one time off of type 'Annual Time Off 2021' for multiple employees (i.e. Anita, Abigail and Audrey) -> validate -> refuse -> set to draft -> Traceback Behaviour after the PR : No traceback opw-26842777 closes odoo/odoo#79503 X-original-commit: c4103536350ed6c0da93a18992e1f9b733bd845e Signed-off-by: Kevin Baptiste --- addons/hr_holidays/models/hr_leave.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/hr_holidays/models/hr_leave.py b/addons/hr_holidays/models/hr_leave.py index 4044e02d2f3..eca07e59a7e 100644 --- a/addons/hr_holidays/models/hr_leave.py +++ b/addons/hr_holidays/models/hr_leave.py @@ -665,7 +665,7 @@ class HolidaysRequest(models.Model): @api.constrains('state', 'number_of_days', 'holiday_status_id') def _check_holidays(self): for holiday in self: - if holiday.holiday_type != 'employee' or not holiday.employee_id or holiday.holiday_status_id.requires_allocation == 'no': + if holiday.holiday_type != 'employee' or not holiday.employee_id or not holiday.holiday_status_id or holiday.holiday_status_id.requires_allocation == 'no': continue mapped_days = holiday.holiday_status_id.get_employees_days([holiday.employee_id.id], holiday.date_from) leave_days = mapped_days[holiday.employee_id.id][holiday.holiday_status_id.id]