From dfdc06fe4332b3de97a3b1f8f554ce6adc3b948d Mon Sep 17 00:00:00 2001
From: Prakash Prajapati <ppr@odoo.com>
Date: Wed, 19 Jul 2017 19:54:51 +0530
Subject: [PATCH] [IMP] base_settings,...: Improve usability to tend towards a
 perfect onboarding.

Purpose
=======

Lots of small things could be improved in the general settings (labels to rename, layout issues,...)

Specifications
==============

- auth_oauth: Remove useless title
- base_gengo,  : Fix layout issue due to missing oe_inline class
- base_setup: Modify Inter_company_rule labels
- google_calendar: Remove technical menuitem leading to general settings
- ir_actions_todo, ir_ui_menu, mail_message_subtype: Add a handle widget on the line instead of displaying the sequence
---
 addons/auth_signup/views/res_config_settings_views.xml     | 2 +-
 addons/base_gengo/views/res_config_settings_views.xml      | 4 ++--
 addons/base_setup/views/res_config_settings_views.xml      | 7 ++++---
 addons/google_calendar/views/res_config_settings_views.xml | 7 -------
 addons/mail/views/mail_message_subtype_views.xml           | 2 +-
 addons/product/views/res_config_settings_views.xml         | 2 +-
 odoo/addons/base/views/ir_actions_views.xml                | 2 +-
 odoo/addons/base/views/ir_filters_views.xml                | 2 +-
 odoo/addons/base/views/ir_ui_menu_views.xml                | 2 +-
 odoo/addons/base/views/report_paperformat_views.xml        | 2 +-
 10 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/addons/auth_signup/views/res_config_settings_views.xml b/addons/auth_signup/views/res_config_settings_views.xml
index 0f4a5810ce8..3028aa4e8bd 100644
--- a/addons/auth_signup/views/res_config_settings_views.xml
+++ b/addons/auth_signup/views/res_config_settings_views.xml
@@ -7,7 +7,7 @@
             <field name="inherit_id" ref="base_setup.res_config_settings_view_form"/>
             <field name="arch" type="xml">
                 <xpath expr="//div[@id='access_rights']" position="after">
-                    <div class="col-xs-12 col-md-6 o_setting_box" title="If unchecked, only invited users may sign up.">
+                    <div class="col-xs-12 col-md-6 o_setting_box">
                         <div class="o_setting_left_pane">
                         </div>
                         <div class="o_setting_right_pane">
diff --git a/addons/base_gengo/views/res_config_settings_views.xml b/addons/base_gengo/views/res_config_settings_views.xml
index 5db3fb33dc7..a7cbb3641e9 100644
--- a/addons/base_gengo/views/res_config_settings_views.xml
+++ b/addons/base_gengo/views/res_config_settings_views.xml
@@ -21,13 +21,13 @@
                     </div>
                     <div name="gengo_auto_approve" attrs="{'invisible': [('module_base_gengo','=',False)]}">
                         <div name="gengo_auto_approve">
-                            <field name="gengo_auto_approve"/>
+                            <field name="gengo_auto_approve" class="oe_inline"/>
                             <label for="id" string="Auto Approve Translation"/>
                         </div>
                     </div>
                     <div name="gengo_sandbox" attrs="{'invisible': [('module_base_gengo','=',False)]}">
                         <div name="gengo_sandbox">
-                            <field name="gengo_sandbox"/>
+                            <field name="gengo_sandbox" class="oe_inline"/>
                             <label for="id" string="Sandbox Mode"/>
                         </div>
                     </div>
diff --git a/addons/base_setup/views/res_config_settings_views.xml b/addons/base_setup/views/res_config_settings_views.xml
index f10dd6244e2..aaa5be112c1 100644
--- a/addons/base_setup/views/res_config_settings_views.xml
+++ b/addons/base_setup/views/res_config_settings_views.xml
@@ -97,7 +97,7 @@
                                                 <button name="%(base.action_res_company_form)d" icon="fa-arrow-right" type="action" string="Companies" class="btn-link"/>
                                             </div>
                                             <div id="company_share_partner">
-                                                <field name="company_share_partner"/>
+                                                <field name="company_share_partner" class="oe_inline"/>
                                                 <label string="Common Contact Book" class="o_light_label" for="company_share_partner"/>
                                             </div>
                                         </div>
@@ -108,9 +108,10 @@
                                         <field name="module_inter_company_rules" widget="upgrade_boolean"/>
                                     </div>
                                     <div class="o_setting_right_pane">
-                                        <label string="Inter-Company Transactions" for="module_inter_company_rules"/>
+                                        <label string="Inter Company Flows" for="module_inter_company_rules"/>
+                                        <span class="fa fa-lg fa-building-o"/>
                                         <div class="text-muted">
-                                            Automate inter-company transactions
+                                            the creation of documents between your companies
                                         </div>
                                         <div class="content-group" attrs="{'invisible': [('module_inter_company_rules','=',False)]}" id="inter_companies_rules">
                                             <div class="mt16 text-warning"><strong>Save</strong> this page and come back here to set up the feature.</div>
diff --git a/addons/google_calendar/views/res_config_settings_views.xml b/addons/google_calendar/views/res_config_settings_views.xml
index a7874c34c69..63f405863bc 100644
--- a/addons/google_calendar/views/res_config_settings_views.xml
+++ b/addons/google_calendar/views/res_config_settings_views.xml
@@ -18,11 +18,4 @@
                 </div>
             </field>
         </record>
-
-        <menuitem id="menu_calendar_google_tech_config"
-            name="API Credentials"
-            parent="calendar.menu_calendar_configuration"
-            groups="base.group_no_one"
-            action="base_setup.action_general_configuration"/>
-
 </odoo>
diff --git a/addons/mail/views/mail_message_subtype_views.xml b/addons/mail/views/mail_message_subtype_views.xml
index 1aa6123b3d7..2672459e9d9 100644
--- a/addons/mail/views/mail_message_subtype_views.xml
+++ b/addons/mail/views/mail_message_subtype_views.xml
@@ -8,8 +8,8 @@
             <field name="priority">10</field>
             <field name="arch" type="xml">
                 <tree string="Subtype">
+                    <field name="sequence" widget="handle"/>
                     <field name="name"/>
-                    <field name="sequence"/>
                     <field name="res_model"/>
                     <field name="default"/>
                 </tree>
diff --git a/addons/product/views/res_config_settings_views.xml b/addons/product/views/res_config_settings_views.xml
index b67e2708774..88d1de1eaff 100644
--- a/addons/product/views/res_config_settings_views.xml
+++ b/addons/product/views/res_config_settings_views.xml
@@ -6,7 +6,7 @@
             <field name="inherit_id" ref="base_setup.res_config_settings_view_form"/>
             <field name="arch" type="xml">
                 <xpath expr="//div[@id='company_share_partner']" position="after">
-                    <field name="company_share_product"/>
+                    <field name="company_share_product" class="oe_inline"/>
                     <label string="Common Product Catalog" class="o_light_label" for="company_share_product"/>
                 </xpath>
                 <xpath expr="//div[@id='multi_company']" position="before">
diff --git a/odoo/addons/base/views/ir_actions_views.xml b/odoo/addons/base/views/ir_actions_views.xml
index b2d62493177..a64f578217b 100644
--- a/odoo/addons/base/views/ir_actions_views.xml
+++ b/odoo/addons/base/views/ir_actions_views.xml
@@ -390,7 +390,7 @@ env['res.partner'].create({'name': partner_name})
             <field name="name">Config Wizard Steps</field>
             <field name="arch" type="xml">
                 <tree string="Config Wizard Steps">
-                    <field name="sequence"/>
+                    <field name="sequence" widget='handle'/>
                     <field name="action_id"/>
                     <field name="state" readonly="1"/>
                     <button name="action_launch" states="open" string="Launch" type="object" icon="fa-cogs" help="Launch Configuration Wizard"/>
diff --git a/odoo/addons/base/views/ir_filters_views.xml b/odoo/addons/base/views/ir_filters_views.xml
index 7faf7ded0b7..cc084386cde 100644
--- a/odoo/addons/base/views/ir_filters_views.xml
+++ b/odoo/addons/base/views/ir_filters_views.xml
@@ -57,7 +57,7 @@
             </field>
         </record>
         <record id="actions_ir_filters_view" model="ir.actions.act_window">
-            <field name="name">Filters</field>
+            <field name="name">User-defined Filters</field>
             <field name="type">ir.actions.act_window</field>
             <field name="res_model">ir.filters</field>
         </record>
diff --git a/odoo/addons/base/views/ir_ui_menu_views.xml b/odoo/addons/base/views/ir_ui_menu_views.xml
index 06651af015f..16702ce3cda 100644
--- a/odoo/addons/base/views/ir_ui_menu_views.xml
+++ b/odoo/addons/base/views/ir_ui_menu_views.xml
@@ -54,7 +54,7 @@
             <field eval="8" name="priority"/>
             <field name="arch" type="xml">
                 <tree string="Menu">
-                    <field name="sequence"/>
+                    <field name="sequence" widget='handle'/>
                     <field icon="icon" name="complete_name" string="Menu"/>
                 </tree>
             </field>
diff --git a/odoo/addons/base/views/report_paperformat_views.xml b/odoo/addons/base/views/report_paperformat_views.xml
index 1f48320d088..1cdd4104524 100644
--- a/odoo/addons/base/views/report_paperformat_views.xml
+++ b/odoo/addons/base/views/report_paperformat_views.xml
@@ -63,7 +63,7 @@
             />
         <menuitem
             id="reports_menuitem"
-            name="Reporting"
+            name="Reports"
             parent="reporting_menuitem"
             action="reports_action"
             sequence="3"