From dfbe78e9e00798ec017ee0906c01dd200a3ada09 Mon Sep 17 00:00:00 2001
From: "Chrysanthe (chgo)" <chgo@odoo.com>
Date: Thu, 2 Nov 2023 11:04:38 +0100
Subject: [PATCH] [FIX] website_forum: fix avatar renderer
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit allows avatar that would not be squared to be rendered with
a correct aspect ratio inside Forum.

Before these changes, if the user avatar was not uploaded in a squared
size, it would be stretched while being rendered inside the forum UI.

To solve this issue, we simply add the `o_object_fit_cover` class to
these avatars, ensuring they are well rendered.

We also changed the resolution to 128x128, to provide a better render.

task-3580131

closes odoo/odoo#140660

Signed-off-by: Stéphane Debauche (std) <std@odoo.com>
---
 addons/website_forum/views/forum_forum_templates_layout.xml | 2 +-
 addons/website_forum/views/forum_forum_templates_tools.xml  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/website_forum/views/forum_forum_templates_layout.xml b/addons/website_forum/views/forum_forum_templates_layout.xml
index 5e86735afc5..90007c88984 100644
--- a/addons/website_forum/views/forum_forum_templates_layout.xml
+++ b/addons/website_forum/views/forum_forum_templates_layout.xml
@@ -273,7 +273,7 @@
         <a t-attf-href="/forum/user/#{ uid }?forum_id=#{ forum.id if forum else '' }&amp;forum_origin=#{ request.httprequest.path }"
             class="btn w-100 py-1 text-start d-flex align-items-center" data-bs-toggle="tooltip" data-trigger="hover"
             title="My profile">
-            <img class="o_wforum_avatar rounded-circle" t-att-src="request.website.image_url(user, 'avatar_128', '60x60')" alt="Avatar"/>
+            <img class="o_wforum_avatar rounded-circle o_object_fit_cover" t-att-src="request.website.image_url(user, 'avatar_128', '60x60')" alt="Avatar"/>
             <div class="d-flex flex-column justify-content-center ms-2">
                 <h6 class="mb-1" t-out="user_id.name"/>
                 <small class="text-reset opacity-50"><t t-out="user_id.karma"/> XP</small>
diff --git a/addons/website_forum/views/forum_forum_templates_tools.xml b/addons/website_forum/views/forum_forum_templates_tools.xml
index c5df1581387..cf97e50acf2 100644
--- a/addons/website_forum/views/forum_forum_templates_tools.xml
+++ b/addons/website_forum/views/forum_forum_templates_tools.xml
@@ -131,7 +131,7 @@
     <t t-if="allow_biography and object.can_display_biography and request.env.user.karma >= website.karma_profile_min" t-set="bio_popover_data">
         <div class="o_wforum_bio_popover_wrap d-flex transition-fade">
             <div class="d-flex flex-column">
-                <img class="o_wforum_avatar flex-shrink-0 rounded me-3" t-att-src="request.website.image_url(object.create_uid, 'avatar_128', '60x60')" alt="Avatar"/>
+                <img class="o_wforum_avatar flex-shrink-0 rounded me-3" t-att-src="request.website.image_url(object.create_uid, 'avatar_128', '128x128')" alt="Avatar"/>
             </div>
             <div>
                 <h5 class="o_wforum_bio_popover_name mb-0" t-field="object.create_uid" t-options='{"widget": "contact", "country_image": True, "fields": ["name"]}'/>
@@ -148,7 +148,7 @@
             <t t-set="user_profile_url" t-valuef="/forum/user/#{ object.create_uid.id }?forum_id=#{ object.forum_id.id }&amp;forum_origin=#{ request.httprequest.path }"/>
         </t>
         <a t-if="show_image" t-att-href="user_profile_url or '#'" t-attf-class="o_wforum_author_pic position-relative #{ 'pe-none' if not user_profile_url else '' }">
-            <img t-attf-class="o_wforum_avatar rounded-circle #{'me-2' if show_name or show_date or show_karma else '' } #{_image_classes}" t-att-src="website.image_url(object.create_uid, 'avatar_128', '40x40')" alt="Avatar"/>
+            <img t-attf-class="o_wforum_avatar rounded-circle o_object_fit_cover #{'me-2' if show_name or show_date or show_karma else '' } #{_image_classes}" t-att-src="website.image_url(object.create_uid, 'avatar_128', '60x60')" alt="Avatar"/>
         </a>
         <div t-if="show_name or show_date or show_karma" t-attf-class="d-flex #{ 'align-items-baseline' if compact else 'flex-column justify-content-around' } #{ 'ms-2' if show_image else '' }">
             <a t-att-href="user_profile_url" t-attf-class="my-0 text-reset h6 #{ 'small' if compact else ''}" t-field="object.create_uid" t-options='{"widget": "contact", "fields": ["name"]}'/>