From df104e71011509b2a8a5ba3b3035cbc46f19147e Mon Sep 17 00:00:00 2001 From: Ahmad Khanalizadeh Date: Wed, 18 Oct 2023 08:40:59 +0000 Subject: [PATCH] [REV] point_of_sale: traceback when downloading the report The commit https://github.com/odoo/odoo/pull/137446/commits/a0b59559 leads to a traceback when clicking on "Download sale report" button when closing the session. Traceback: ``` tuple index out of range Traceback (most recent call last): File "/data/build/odoo/addons/web/controllers/report.py", line 113, in report_download response = self.report_routes(reportname, docids=docids, converter=converter, context=context) File "/data/build/odoo/odoo/http.py", line 697, in route_wrapper result = endpoint(self, *args, **params_ok) File "/data/build/odoo/addons/web/controllers/report.py", line 42, in report_routes pdf = report.with_context(context)._render_qweb_pdf(reportname, docids, data=data)[0] File "/data/build/odoo/addons/account/models/ir_actions_report.py", line 58, in _render_qweb_pdf return super()._render_qweb_pdf(report_ref, res_ids=res_ids, data=data) File "/data/build/odoo/odoo/addons/base/models/ir_actions_report.py", line 819, in _render_qweb_pdf collected_streams = self._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids) File "/data/build/odoo/addons/account_edi_ubl_cii/models/ir_actions_report.py", line 58, in _render_qweb_pdf_prepare_streams collected_streams = super()._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids) File "/data/build/odoo/addons/account_edi/models/ir_actions_report.py", line 14, in _render_qweb_pdf_prepare_streams collected_streams = super()._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids) File "/data/build/odoo/addons/account/models/ir_actions_report.py", line 20, in _render_qweb_pdf_prepare_streams return super()._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids) File "/data/build/odoo/odoo/addons/base/models/ir_actions_report.py", line 708, in _render_qweb_pdf_prepare_streams html = self.with_context(**additional_context)._render_qweb_html(report_ref, res_ids_wo_stream, data=data)[0] File "/data/build/enterprise/web_studio/models/ir_actions_report.py", line 19, in _render_qweb_html return super(IrActionsReport, self)._render_qweb_html(report_ref, docids, data) File "/data/build/odoo/odoo/addons/base/models/ir_actions_report.py", line 895, in _render_qweb_html data = self._get_rendering_context(report, docids, data) File "/data/build/odoo/odoo/addons/base/models/ir_actions_report.py", line 910, in _get_rendering_context data.update(report_model._get_report_values(docids, data=data)) File "/data/build/odoo/addons/point_of_sale/models/pos_order.py", line 1538, in _get_report_values data.update(self.get_sale_details(data['date_start'], data['date_stop'], configs.ids, data['session_ids'])) File "/data/build/odoo/addons/pos_daily_sales_reports/models/pos_daily_sales_reports.py", line 68, in get_sale_details user_currency = config_currencies[0] File "/data/build/odoo/odoo/models.py", line 5901, in __getitem__ return self.browse((self._ids[key],)) IndexError: tuple index out of range ``` opw-3558365 closes odoo/odoo#139128 X-original-commit: 8b19e29e8ead8229cebbb6224979264a59334209 Signed-off-by: Vlad Stroia (vlst) Signed-off-by: Ahmad Khanalizadeh (khah) --- addons/point_of_sale/models/report_sale_details.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/point_of_sale/models/report_sale_details.py b/addons/point_of_sale/models/report_sale_details.py index c893cf77328..8b42f7dbe9b 100644 --- a/addons/point_of_sale/models/report_sale_details.py +++ b/addons/point_of_sale/models/report_sale_details.py @@ -325,7 +325,7 @@ class ReportSaleDetails(models.AbstractModel): data = dict(data or {}) # initialize data keys with their value if provided, else None data.update({ - 'session_ids': data.get('session_ids'), + 'session_ids': data.get('session_ids') or docids, 'config_ids': data.get('config_ids'), 'date_start': data.get('date_start'), 'date_stop': data.get('date_stop')