From dee5c31264be4c13f36615f5e4fb2a375c1c38d8 Mon Sep 17 00:00:00 2001
From: Olivier Dony <odo@openerp.com>
Date: Thu, 20 Apr 2017 13:21:57 +0200
Subject: [PATCH] [FIX] mass_mailing: deduplicate recipients within campaign by
 default

It is safer to avoid duplicates within a campaign,
so this should be turned on by default. Especially true
because campaign are often created without opening the
form view (quick create)

Also improved the description of the boolean option,
and made it editable in the form view, in case someone
wants ho really create a multi-step campaign.
---
 addons/mass_mailing/models/mass_mailing.py       | 8 ++++----
 addons/mass_mailing/views/mass_mailing_views.xml | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/addons/mass_mailing/models/mass_mailing.py b/addons/mass_mailing/models/mass_mailing.py
index 86ded7246b9..922ecea9fe7 100644
--- a/addons/mass_mailing/models/mass_mailing.py
+++ b/addons/mass_mailing/models/mass_mailing.py
@@ -153,10 +153,10 @@ class MassMailingCampaign(models.Model):
     mass_mailing_ids = fields.One2many(
         'mail.mass_mailing', 'mass_mailing_campaign_id',
         string='Mass Mailings')
-    unique_ab_testing = fields.Boolean(string='AB Testing',
-        help='If checked, recipients will be mailed only once, allowing to send '
-             'various mailings in a single campaign to test the effectiveness '
-             'of the mailings.')
+    unique_ab_testing = fields.Boolean(string='Allow A/B Testing', default=True,
+        help='If checked, recipients will be mailed only once for the whole campaign. '
+             'This lets you send different mailings to randomly selected recipients and test '
+             'the effectiveness of the mailings, without causing duplicate messages.')
     color = fields.Integer(string='Color Index')
     clicks_ratio = fields.Integer(compute="_compute_clicks_ratio", string="Number of clicks")
     # stat fields
diff --git a/addons/mass_mailing/views/mass_mailing_views.xml b/addons/mass_mailing/views/mass_mailing_views.xml
index ef33f09ef2e..558782d7d2a 100644
--- a/addons/mass_mailing/views/mass_mailing_views.xml
+++ b/addons/mass_mailing/views/mass_mailing_views.xml
@@ -691,6 +691,7 @@
                             <field name="name" string="Campaign Name"/>
                             <field name="user_id"/>
                             <field name="tag_ids" widget="many2many_tags" options="{'no_create_edit': True}"/>
+                            <field name="unique_ab_testing" groups="base.group_no_one"/>
                         </group>
                         <notebook>
                             <page string="Tracking">