From de0acbfec61b602175371a1c8fe36799ddb346df Mon Sep 17 00:00:00 2001 From: Yannick Tivisse Date: Tue, 22 Sep 2015 14:08:11 +0200 Subject: [PATCH] [IMP] hr_equipment,hr_recruitment : Clean 2 methods --- addons/hr_equipment/models/hr_equipment.py | 11 ++++------- addons/hr_recruitment/models/hr_recruitment.py | 6 ++---- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/addons/hr_equipment/models/hr_equipment.py b/addons/hr_equipment/models/hr_equipment.py index 8f5b0a2d522..b363252be13 100644 --- a/addons/hr_equipment/models/hr_equipment.py +++ b/addons/hr_equipment/models/hr_equipment.py @@ -249,16 +249,13 @@ class HrEquipmentRequest(models.Model): @api.multi def archive_equipment_request(self): - """ Archive an hr.equipment.request as it was refused """ - for equipment_request in self: - equipment_request.write({'active': False}) + self.write({'active': False}) @api.multi def reset_equipment_request(self): - """ Reinsert the equipment request into the maintenance pipe""" - for equipment_request in self: - first_stage_obj = self.env['hr.equipment.stage'].search([], order="sequence asc", limit=1) - equipment_request.write({'active': True, 'stage_id': first_stage_obj.id}) + """ Reinsert the equipment request into the maintenance pipe in the first stage""" + first_stage_obj = self.env['hr.equipment.stage'].search([], order="sequence asc", limit=1) + self.write({'active': True, 'stage_id': first_stage_obj.id}) @api.onchange('employee_id', 'department_id') def onchange_department_or_employee_id(self): diff --git a/addons/hr_recruitment/models/hr_recruitment.py b/addons/hr_recruitment/models/hr_recruitment.py index 954da2d2225..60faef49674 100644 --- a/addons/hr_recruitment/models/hr_recruitment.py +++ b/addons/hr_recruitment/models/hr_recruitment.py @@ -439,13 +439,11 @@ class Applicant(models.Model): @api.multi def archive_applicant(self): - """ Archive an hr.applicant as it was refused """ - for applicant in self: - applicant.write({'active': False}) + self.write({'active': False}) @api.multi def reset_applicant(self): - """ Reinsert the applicant into the recruitment pipe""" + """ Reinsert the applicant into the recruitment pipe in the first stage""" for applicant in self: first_stage_obj = self.env['hr.recruitment.stage'].search([('job_ids', 'in', applicant.job_id.id)], order="sequence asc", limit=1) applicant.write({'active': True, 'stage_id': first_stage_obj.id})