From ddfa8768cc9aa0685d8908741936093e5aa335ea Mon Sep 17 00:00:00 2001 From: Jason Van Malder Date: Tue, 7 Jan 2020 14:31:35 +0000 Subject: [PATCH] [FIX] web: fix question error message translation Issue - Take a v13 runbot - Open survey's app - Open one of the surveys - Click on edit - Click on a question - Open 'option tab' - Make sur the field 'mandatory answer' is true - Try to translate field 'error message' -> Error Cause this occur because because we try to update the model survey.question from the list coming from survey.survey which mean that the record.viewType is list and not form. Solution As we are looking for the field name we can simply use ev.data.fieldName. Another solution should be to use this.viewType instead of the record one. OPW-2157631 closes odoo/odoo#42952 X-original-commit: ad115d2710aec2b4ff7d4077714a1816cdfb433e Signed-off-by: Jason Van Malder --- addons/web/static/src/js/views/basic/basic_controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web/static/src/js/views/basic/basic_controller.js b/addons/web/static/src/js/views/basic/basic_controller.js index ddc1795cb14..58e03efb94a 100644 --- a/addons/web/static/src/js/views/basic/basic_controller.js +++ b/addons/web/static/src/js/views/basic/basic_controller.js @@ -837,7 +837,7 @@ var BasicController = AbstractController.extend(FieldManagerMixin, { this.translationDialog = new TranslationDialog(this, { domain: result.domain, searchName: result.context.search_default_name, - fieldName: record.fieldsInfo[record.viewType][ev.data.fieldName].name, + fieldName: ev.data.fieldName, userLanguageValue: ev.target.value || '', dataPointID: record.id, isComingFromTranslationAlert: ev.data.isComingFromTranslationAlert,