From dd72fef73f8fbe8f152866abb99badbb34ae06e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Wed, 18 Jul 2018 11:08:44 +0200 Subject: [PATCH] [IMP] base: do not format email for partners not having email Currently if a partner has a void email, its email_formatted field holds a value like "Raoul Grosbedon " which is quite rarely considered as a valid email address. Minimal fix for this field is to return a void value if there is no email. Having a void return is easier to manipulate for callers in order to handle it. This commit is linked to task ID 1860049 and PR #25824. --- odoo/addons/base/models/res_partner.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/odoo/addons/base/models/res_partner.py b/odoo/addons/base/models/res_partner.py index a477befcd24..0efcc576da2 100644 --- a/odoo/addons/base/models/res_partner.py +++ b/odoo/addons/base/models/res_partner.py @@ -374,7 +374,10 @@ class Partner(models.Model): @api.depends('name', 'email') def _compute_email_formatted(self): for partner in self: - partner.email_formatted = formataddr((partner.name or u"False", partner.email or u"False")) + if partner.email: + partner.email_formatted = formataddr((partner.name or u"False", partner.email or u"False")) + else: + partner.email_formatted = '' @api.depends('is_company') def _compute_company_type(self):