From dc2a93792aa1fdf6f62ed6d30060fa9f56011abb Mon Sep 17 00:00:00 2001 From: Suraj Shukla Date: Thu, 10 Jan 2019 10:14:01 +0000 Subject: [PATCH] [IMP] web: properly set margin for the kanban dropdown While everything looks pretty perfect without this commit, setting margin on `.dropdown-toggle` and not on its parent `.o_dropdown_kanban` itself will cause glitches in Studio. While selecting the dropdown using Studio, the class responsible for displaying outline (that indicates the selection) is applied on '.o_dropdown_kanban', which is okay, but the actual child is positioned using margin, so the outline on parent div looks ugly. This commit fixes the issue by applying the margin on the proper selector. Task 1916583 closes odoo/odoo#30049 Signed-off-by: Martin Geubelle (mge) --- addons/web/static/src/scss/kanban_view.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web/static/src/scss/kanban_view.scss b/addons/web/static/src/scss/kanban_view.scss index c1b05807ddf..2cb209e466e 100644 --- a/addons/web/static/src/scss/kanban_view.scss +++ b/addons/web/static/src/scss/kanban_view.scss @@ -196,13 +196,13 @@ .o_dropdown_kanban { @include o-position-absolute($o-kanban-inside-vgutter, $o-kanban-inside-hgutter); visibility: hidden; + margin: (-$o-kanban-inside-vgutter) (-$o-kanban-inside-hgutter) 0 0; @include media-breakpoint-down(sm) { visibility: visible; } .dropdown-toggle { @include o-kanban-dropdown; - margin: (-$o-kanban-inside-vgutter - 1px) (-$o-kanban-inside-hgutter - 1px) 0 0; } &.show .dropdown-toggle { @include o-kanban-dropdown-open;