From dba74ed353e9acdb7c0ea002724ed420f4f26d15 Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Thu, 23 Apr 2020 14:35:31 +0000 Subject: [PATCH] [IMP] website_blog: rename key for viewed post and avoid write Avoid extra call to session_store.save if we don't touch to the session Use an explicit name to storage post_viewed in the session task-2211013 Co-authored-by: Romain Derie Co-authored-by: Jeremy Kersten --- addons/website_blog/controllers/main.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/addons/website_blog/controllers/main.py b/addons/website_blog/controllers/main.py index 95828b6a1ab..ad3a629f6bd 100644 --- a/addons/website_blog/controllers/main.py +++ b/addons/website_blog/controllers/main.py @@ -251,9 +251,13 @@ class WebsiteBlog(http.Controller): } response = request.render("website_blog.blog_post_complete", values) - request.session[request.session.sid] = request.session.get(request.session.sid, []) - if not (blog_post.id in request.session[request.session.sid]): - request.session[request.session.sid].append(blog_post.id) + if blog_post.id not in request.session.get('posts_viewed', []): + if not request.session.get('posts_viewed'): + request.session['posts_viewed'] = [] + + request.session['posts_viewed'].append(blog_post.id) + request.session.modified = True + # Increase counter blog_post.sudo().write({ 'visits': blog_post.visits + 1,