From d9eea928b3379f481dd17afe830a9cb738829f68 Mon Sep 17 00:00:00 2001
From: amdi-odoo <amdi@odoo.com>
Date: Wed, 12 Apr 2023 09:57:16 +0000
Subject: [PATCH] [IMP] utm: improve campaign UI

Purpose
=======
Give users a better experience while using the utm campaign module.

Specifications
==============
* Add a filter called "My Campaigns" filtering on the current user_id.
* Add a groupby Tags.
* Always underline the Tags field in the campaign quick create.
* When duplicating a campaign, do not copy the stage and make it
restart the pipe.
* In the list view:
  - Change the column name from "Campaign Name" to "Name".
  - Add bold on the stage field.
  - Add the avatar widget to the Responsible field.
* For the edit stage modal:
  - Make the dialog smaller.
  - Only display the name field.
  - Add a placeholder to the name field.

Task-3240966

Part-of: odoo/odoo#116230
---
 addons/utm/models/utm_campaign.py       |  2 +-
 addons/utm/views/utm_campaign_views.xml | 13 +++++++++----
 addons/utm/views/utm_stage_views.xml    | 16 ++++++++++++++++
 3 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/addons/utm/models/utm_campaign.py b/addons/utm/models/utm_campaign.py
index 924a67a3214..603f6c6ae74 100644
--- a/addons/utm/models/utm_campaign.py
+++ b/addons/utm/models/utm_campaign.py
@@ -20,7 +20,7 @@ class UtmCampaign(models.Model):
     stage_id = fields.Many2one(
         'utm.stage', string='Stage', ondelete='restrict', required=True,
         default=lambda self: self.env['utm.stage'].search([], limit=1),
-        group_expand='_group_expand_stage_ids')
+        copy=False, group_expand='_group_expand_stage_ids')
     tag_ids = fields.Many2many(
         'utm.tag', 'utm_tag_rel',
         'tag_id', 'campaign_id', string='Tags')
diff --git a/addons/utm/views/utm_campaign_views.xml b/addons/utm/views/utm_campaign_views.xml
index 9a5b25d2ad8..ed945e9f1b0 100644
--- a/addons/utm/views/utm_campaign_views.xml
+++ b/addons/utm/views/utm_campaign_views.xml
@@ -9,12 +9,17 @@
                 <field name="tag_ids"/>
                 <field name="user_id"/>
                 <field name="is_auto_campaign"/>
+                <filter string="My Campaigns" name="filter_assigned_to_me" domain="[('user_id', '=', uid)]"
+                    help="Campaigns that are assigned to me"/>
+                <separator/>
                 <filter string="Archived" name="filter_inactive" domain="[('active', '=', False)]"/>
                 <group expand="0" string="Group By">
                     <filter string="Stage" name="group_stage_id"
                         context="{'group_by': 'stage_id'}"/>
                     <filter string="Responsible" name="group_user_id"
                         context="{'group_by': 'user_id'}"/>
+                    <filter string="Tags" name="group_tags_id"
+                        context="{'group_by': 'tag_ids'}"/>
                 </group>
             </search>
         </field>
@@ -51,10 +56,10 @@
         <field name="model">utm.campaign</field>
         <field name="arch" type="xml">
             <tree string="UTM Campaigns" multi_edit="1" sample="1">
-                <field name="title" readonly="1"/>
+                <field name="title" string="Name" readonly="1"/>
                 <field name="name" invisible="1"/>
-                <field name="user_id"/>
-                <field name="stage_id"/>
+                <field name="user_id" widget="many2one_avatar_user"/>
+                <field name="stage_id" decoration-bf="1"/>
                 <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}"/>
             </tree>
         </field>
@@ -70,7 +75,7 @@
                     <field name="name" invisible="1"/>
                     <field class="o_text_overflow" name="title" string="Campaign Name" placeholder="e.g. Black Friday"/>
                     <field name="user_id" widget="many2one_avatar_user" domain="[('share', '=', False)]"/>
-                    <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color', 'no_create_edit': True}"/>
+                    <field name="tag_ids" widget="many2many_tags" class="o_field_highlight" options="{'color_field': 'color', 'no_create_edit': True}"/>
                 </group>
             </form>
         </field>
diff --git a/addons/utm/views/utm_stage_views.xml b/addons/utm/views/utm_stage_views.xml
index 1500e29e6d8..bbc6c9caaf5 100644
--- a/addons/utm/views/utm_stage_views.xml
+++ b/addons/utm/views/utm_stage_views.xml
@@ -22,6 +22,22 @@
         </field>
     </record>
 
+    <record id="utm_stage_view_form" model="ir.ui.view">
+        <field name="name">utm.stage.view.form</field>
+        <field name="model">utm.stage</field>
+        <field name="arch" type="xml">
+            <form string="Stages">
+                <sheet>
+                    <group>
+                        <group>
+                            <field name="name" placeholder='e.g. "Brainstorming"'/>
+                        </group>
+                    </group>
+                </sheet>
+            </form>
+        </field>
+    </record>
+
     <record id="action_view_utm_stage" model="ir.actions.act_window">
         <field name="name">UTM Stages</field>
         <field name="res_model">utm.stage</field>