From d9b51737d3dc1862c1adc054bc0451c2b02baa72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= Date: Tue, 3 Jan 2023 14:18:27 +0000 Subject: [PATCH] [REF] spreadsheet: use existing helper to escape regexp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit closes odoo/odoo#109010 Signed-off-by: Rémi Rahir (rar) --- .../src/global_filters/plugins/global_filters_core_plugin.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js b/addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js index 89672629265..55704453486 100644 --- a/addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js +++ b/addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js @@ -27,6 +27,7 @@ import spreadsheet from "@spreadsheet/o_spreadsheet/o_spreadsheet_extended"; import CommandResult from "@spreadsheet/o_spreadsheet/cancelled_reason"; import { checkFiltersTypeValueCombination } from "@spreadsheet/global_filters/helpers"; import { _t } from "@web/core/l10n/translation"; +import { escapeRegExp } from "@web/core/utils/strings"; export class GlobalFiltersCorePlugin extends spreadsheet.CorePlugin { constructor(config) { @@ -207,7 +208,7 @@ export class GlobalFiltersCorePlugin extends spreadsheet.CorePlugin { */ _updateFilterLabelInFormulas(currentLabel, newLabel) { const sheetIds = this.getters.getSheetIds(); - currentLabel = currentLabel.replace(/[.*+?^${}()|[\]\\]/g, "\\$&"); + currentLabel = escapeRegExp(currentLabel); for (const sheetId of sheetIds) { for (const cell of Object.values(this.getters.getCells(sheetId))) { if (cell.isFormula) {