From d98f4d2cf37e98b7924aa7f3219120fe31a0daad Mon Sep 17 00:00:00 2001
From: Pierre Paridans <app@odoo.com>
Date: Mon, 10 Oct 2022 12:58:52 +0000
Subject: [PATCH] [FIX] web: add support for switch type in Burger's UserMenu
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit adds an implementation of the UserMenu item's type 'switch'
for the BurgerMenu (used in smaller screen).

Note: this commit also adds unit tests for the BurgerUserMenu ; the
asserts are largely inspired by the regular UserMenu tests.

closes odoo/odoo#103102

X-original-commit: 0653ec8672e5878e40c804ea569dfccbd6105edc
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
---
 .../burger_user_menu/burger_user_menu.xml     |  12 +-
 .../{ => burger_menu}/burger_menu_tests.js    |   0
 .../burger_menu/burger_user_menu_tests.js     | 146 ++++++++++++++++++
 3 files changed, 155 insertions(+), 3 deletions(-)
 rename addons/web/static/tests/mobile/webclient/{ => burger_menu}/burger_menu_tests.js (100%)
 create mode 100644 addons/web/static/tests/mobile/webclient/burger_menu/burger_user_menu_tests.js

diff --git a/addons/web/static/src/webclient/burger_menu/burger_user_menu/burger_user_menu.xml b/addons/web/static/src/webclient/burger_menu/burger_user_menu/burger_user_menu.xml
index 3d2bf58a45c..b2f2548a7f2 100644
--- a/addons/web/static/src/webclient/burger_menu/burger_user_menu/burger_user_menu.xml
+++ b/addons/web/static/src/webclient/burger_menu/burger_user_menu/burger_user_menu.xml
@@ -5,9 +5,15 @@
     <div class="o_user_menu_mobile mt-2">
       <t t-foreach="getElements()" t-as="element" t-key="element_index">
           <t t-if="!element.hide">
-              <t t-if="element.type == 'item'">
-                <a class="dropdown-item py-3 fs-4" t-att-href="element.href or ''" t-esc="element.description" t-on-click.stop.prevent="() => this._onItemClicked(element.callback)"/>
-              </t>
+              <a t-if="element.type == 'item'" class="dropdown-item py-3 fs-4" t-att-href="element.href or ''" t-esc="element.description" t-on-click.stop.prevent="() => this._onItemClicked(element.callback)"/>
+              <CheckBox
+                  t-if="element.type == 'switch'"
+                  value="element.isChecked"
+                  className="'dropdown-item form-switch d-flex flex-row-reverse justify-content-between py-3 fs-4'"
+                  onChange="element.callback"
+              >
+                  <t t-out="element.description"/>
+              </CheckBox>
               <div t-if="element.type == 'separator'" role="separator" class="dropdown-divider"/>
           </t>
       </t>
diff --git a/addons/web/static/tests/mobile/webclient/burger_menu_tests.js b/addons/web/static/tests/mobile/webclient/burger_menu/burger_menu_tests.js
similarity index 100%
rename from addons/web/static/tests/mobile/webclient/burger_menu_tests.js
rename to addons/web/static/tests/mobile/webclient/burger_menu/burger_menu_tests.js
diff --git a/addons/web/static/tests/mobile/webclient/burger_menu/burger_user_menu_tests.js b/addons/web/static/tests/mobile/webclient/burger_menu/burger_user_menu_tests.js
new file mode 100644
index 00000000000..fb160a8f230
--- /dev/null
+++ b/addons/web/static/tests/mobile/webclient/burger_menu/burger_user_menu_tests.js
@@ -0,0 +1,146 @@
+/** @odoo-module **/
+
+import { ormService } from "@web/core/orm_service";
+import { registry } from "@web/core/registry";
+import { hotkeyService } from "@web/core/hotkeys/hotkey_service";
+import { BurgerUserMenu } from "@web/webclient/burger_menu/burger_user_menu/burger_user_menu";
+import { preferencesItem } from "@web/webclient/user_menu/user_menu_items";
+import { userService } from "@web/core/user_service";
+import { makeTestEnv } from "@web/../tests/helpers/mock_env";
+import { makeFakeLocalizationService } from "@web/../tests/helpers/mock_services";
+import { click, getFixture, mount } from "@web/../tests/helpers/utils";
+
+const serviceRegistry = registry.category("services");
+const userMenuRegistry = registry.category("user_menuitems");
+let target;
+let env;
+
+QUnit.module("BurgerUserMenu", {
+    async beforeEach() {
+        serviceRegistry.add("user", userService);
+        serviceRegistry.add("hotkey", hotkeyService);
+        target = getFixture();
+    },
+});
+
+QUnit.test("can be rendered", async (assert) => {
+    env = await makeTestEnv();
+    userMenuRegistry.add("bad_item", function () {
+        return {
+            type: "item",
+            id: "bad",
+            description: "Bad",
+            callback: () => {
+                assert.step("callback bad_item");
+            },
+            sequence: 10,
+        };
+    });
+    userMenuRegistry.add("ring_item", function () {
+        return {
+            type: "item",
+            id: "ring",
+            description: "Ring",
+            callback: () => {
+                assert.step("callback ring_item");
+            },
+            sequence: 5,
+        };
+    });
+    userMenuRegistry.add("frodo_item", function () {
+        return {
+            type: "switch",
+            id: "frodo",
+            description: "Frodo",
+            callback: () => {
+                assert.step("callback frodo_item");
+            },
+            sequence: 11,
+        };
+    });
+    userMenuRegistry.add("separator", function () {
+        return {
+            type: "separator",
+            sequence: 15,
+        };
+    });
+    userMenuRegistry.add("invisible_item", function () {
+        return {
+            type: "item",
+            id: "hidden",
+            description: "Hidden Power",
+            callback: () => {},
+            sequence: 5,
+            hide: true,
+        };
+    });
+    userMenuRegistry.add("eye_item", function () {
+        return {
+            type: "item",
+            id: "eye",
+            description: "Eye",
+            callback: () => {
+                assert.step("callback eye_item");
+            },
+        };
+    });
+    await mount(BurgerUserMenu, target, { env });
+    assert.containsN(target, ".o_user_menu_mobile .dropdown-item", 4);
+    assert.containsOnce(target, ".o_user_menu_mobile .dropdown-item input.form-check-input");
+    assert.containsOnce(target, "div.dropdown-divider");
+    const children = [...(target.querySelector(".o_user_menu_mobile").children || [])];
+    assert.deepEqual(
+        children.map((el) => el.tagName),
+        ["A", "A", "DIV", "DIV", "A"]
+    );
+    const items = [...target.querySelectorAll(".dropdown-item")] || [];
+    assert.deepEqual(
+        items.map((el) => el.textContent),
+        ["Ring", "Bad", "Frodo", "Eye"]
+    );
+    for (const item of items) {
+        click(item);
+    }
+    assert.verifySteps([
+        "callback ring_item",
+        "callback bad_item",
+        "callback frodo_item",
+        "callback eye_item",
+    ]);
+});
+
+QUnit.test("can execute the callback of settings", async (assert) => {
+    const mockRPC = (route) => {
+        if (route === "/web/dataset/call_kw/res.users/action_get") {
+            return Promise.resolve({
+                name: "Change My Preferences",
+                res_id: 0,
+            });
+        }
+    };
+    const testConfig = { mockRPC };
+    serviceRegistry.add("localization", makeFakeLocalizationService());
+    serviceRegistry.add("orm", ormService);
+    const fakeActionService = {
+        name: "action",
+        start() {
+            return {
+                doAction(actionId) {
+                    assert.step("" + actionId.res_id);
+                    assert.step(actionId.name);
+                    return Promise.resolve(true);
+                },
+            };
+        },
+    };
+    serviceRegistry.add("action", fakeActionService, { force: true });
+
+    env = await makeTestEnv(testConfig);
+    userMenuRegistry.add("profile", preferencesItem);
+    await mount(BurgerUserMenu, target, { env });
+    assert.containsOnce(target, ".o_user_menu_mobile .dropdown-item");
+    const item = target.querySelector(".o_user_menu_mobile .dropdown-item");
+    assert.strictEqual(item.textContent, "Preferences");
+    await click(item);
+    assert.verifySteps(["7", "Change My Preferences"]);
+});