From d87f760a2c05495a68c3593dbca07bea20041388 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A9ry=20Debongnie?= Date: Wed, 15 Oct 2014 15:01:12 +0200 Subject: [PATCH] [FIX] correctly check default/shared filters in searchview. They were swapped in the UI, and not in the code. It also shows that using position as reference is fragile. --- addons/web/static/src/js/search.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/web/static/src/js/search.js b/addons/web/static/src/js/search.js index de839036d06..9556ba650b8 100644 --- a/addons/web/static/src/js/search.js +++ b/addons/web/static/src/js/search.js @@ -1625,8 +1625,8 @@ instance.web.search.FavoriteMenu = instance.web.Widget.extend({ save_favorite: function () { var self = this, filter_name = this.$inputs[0].value, - shared_filter = this.$inputs[1].checked, - default_filter = this.$inputs[2].checked; + default_filter = this.$inputs[1].checked, + shared_filter = this.$inputs[2].checked; if (!filter_name.length){ this.do_warn(_t("Error"), _t("Filter name is required.")); this.$inputs.first().focus();