From d7fff1167f4a0debd3dffa0cd4e4f559454ee281 Mon Sep 17 00:00:00 2001
From: "stefanorigano (SRI)" <sri@odoo.com>
Date: Fri, 9 Feb 2024 12:35:07 +0100
Subject: [PATCH] [FIX] website_event_track: fix offcanva's wrong html

Prior to this commit, the position of the `<li>` was not correct.
We had single `<li>` with multiples `<a>` inside, instead of multiples
`<li>` with a single `<a>`.

See relative commit[1] in another PR [2].

[1] https://github.com/odoo/odoo/commit/2d348d58cfa227fa84dc1581d80e81ec58e4cd23
[2] https://github.com/odoo/odoo/pull/145064

task-3718417
part of task-3698364

Part-of: odoo/odoo#152434
---
 .../views/event_track_templates_list.xml      | 20 ++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/addons/website_event_track/views/event_track_templates_list.xml b/addons/website_event_track/views/event_track_templates_list.xml
index a875cc03a7f..16e043a074f 100644
--- a/addons/website_event_track/views/event_track_templates_list.xml
+++ b/addons/website_event_track/views/event_track_templates_list.xml
@@ -73,7 +73,7 @@
             </div>
             <div class="offcanvas-body p-0">
                 <div class="accordion accordion-flush">
-                    <div class="accordion-item">
+                    <div t-if="option_track_wishlist" class="accordion-item">
                         <h2 class="accordion-header">
                             <button class="accordion-button collapsed"
                                 type="button"
@@ -88,19 +88,21 @@
                             <div class="accordion-body pt-0">
                                 <ul class="list-group list-group-flush">
                                     <!-- Optional wishlist filter -->
-                                    <li t-if="option_track_wishlist" class="list-group-item">                         
+                                    <li class="list-group-item border-0 px-0">
                                         <a t-att-href="'/event/%s/track?%s' % (
                                                 slug(event),
                                                 keep_query('*', search_wishlist='')
                                             )"
-                                            class="d-flex align-items-center justify-content-between">
+                                            class="d-flex align-items-center justify-content-between text-reset">
                                             All Talks
                                         </a>
+                                    </li>
+                                    <li class="list-group-item border-0 px-0">
                                         <a t-att-href="'/event/%s/track?%s' % (
                                                 slug(event),
                                                 keep_query('*', search_wishlist='1')
                                             )"
-                                            t-attf-class="d-flex align-items-center justify-content-between #{'active' if search_wishlist else ''}">
+                                            t-attf-class="d-flex align-items-center justify-content-between text-reset #{'active' if search_wishlist else ''}">
                                             Favorites
                                         </a>
                                     </li>
@@ -111,7 +113,7 @@
                     <t t-foreach="tag_categories" t-as="tag_category">
                     <div class="accordion-item">
                         <h2 class="accordion-header">
-                            <button class="accordion-button border-top collapsed"
+                            <button class="accordion-button collapsed"
                                 type="button"
                                 data-bs-toggle="collapse"
                                 t-att-data-bs-target="'.o_wevent_offcanvas_tag_%s' % tag_category.name"
@@ -122,18 +124,18 @@
                         <div t-attf-class="o_wevent_offcanvas_tag_#{tag_category.name} accordion-collapse collapse">
                             <div class="accordion-body pt-0">
                                 <ul class="list-group list-group-flush">
-                                        <li t-if="tag_category.tag_ids and any(tag.color for tag in tag_category.tag_ids)" class="list-group-item">
-                                            <t t-foreach="tag_category.tag_ids" t-as="tag">
+                                    <t t-if="tag_category.tag_ids and any(tag.color for tag in tag_category.tag_ids)" t-foreach="tag_category.tag_ids" t-as="tag">
+                                        <li class="list-group-item border-0 px-0">
                                                 <a t-att-href="'/event/%s/track?%s' % (
                                                         slug(event),
                                                         keep_query('*', tags=str((search_tags - tag).ids if tag in search_tags else (tag | search_tags).ids))
                                                     )"
                                                     t-if="tag.color"
-                                                    t-attf-class="d-flex align-items-center justify-content-between #{'active' if tag in search_tags else ''}">
+                                                    t-attf-class="d-flex align-items-center justify-content-between text-reset #{'active' if tag in search_tags else ''}">
                                                     <t t-out="tag.name"/>
                                                 </a>
-                                            </t>
                                         </li>
+                                    </t>
                                 </ul>
                             </div>
                         </div>