From d7ffac56761f6899301fdb19b80c50d0ef7535ec Mon Sep 17 00:00:00 2001
From: Joseph Caburnay <jcb@odoo.com>
Date: Thu, 17 Dec 2020 10:21:46 +0000
Subject: [PATCH] [FIX] point_of_sale: missing search bar when no pos category

To reproduce:
1. Start an odoo instance without demo with point_of_sale module.
2. Install a generic fiscal local if not automatically installed.
3. Create a product.
4. Open a pos session.
5. BUG: no search bar

This is because the search bar is rendered inside ProductsWidgetControlPanel
which is only rendered when there are categories. Instead, we render it
always but we pass the hasNoCategory information to selectively render
it's part. This now always show the search bar.

closes odoo/odoo#63551

Opw: 2418858
X-original-commit: bf69c811736a81cd95d4bffc06b23c539e4671e6
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
---
 .../Screens/ProductScreen/ProductsWidget.xml  |  4 +-
 .../ProductsWidgetControlPanel.xml            | 52 ++++++++++---------
 2 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/addons/point_of_sale/static/src/xml/Screens/ProductScreen/ProductsWidget.xml b/addons/point_of_sale/static/src/xml/Screens/ProductScreen/ProductsWidget.xml
index 6b3f04bb320..3dfd52766fa 100644
--- a/addons/point_of_sale/static/src/xml/Screens/ProductScreen/ProductsWidget.xml
+++ b/addons/point_of_sale/static/src/xml/Screens/ProductScreen/ProductsWidget.xml
@@ -3,9 +3,7 @@
 
     <t t-name="ProductsWidget" owl="1">
       <div class="products-widget">
-            <t t-if="!hasNoCategories">
-                <ProductsWidgetControlPanel breadcrumbs="breadcrumbs" subcategories="subcategories" />
-            </t>
+            <ProductsWidgetControlPanel breadcrumbs="breadcrumbs" subcategories="subcategories" hasNoCategories="hasNoCategories" />
             <ProductList products="productsToDisplay" searchWord="searchWord" />
         </div>
     </t>
diff --git a/addons/point_of_sale/static/src/xml/Screens/ProductScreen/ProductsWidgetControlPanel.xml b/addons/point_of_sale/static/src/xml/Screens/ProductScreen/ProductsWidgetControlPanel.xml
index 09c17501d52..2c7d7727f7e 100644
--- a/addons/point_of_sale/static/src/xml/Screens/ProductScreen/ProductsWidgetControlPanel.xml
+++ b/addons/point_of_sale/static/src/xml/Screens/ProductScreen/ProductsWidgetControlPanel.xml
@@ -3,36 +3,38 @@
 
     <t t-name="ProductsWidgetControlPanel" owl="1">
         <div class="products-widget-control">
-            <div class="rightpane-header" t-att-class="{
-                'green-border-bottom': !env.pos.config.iface_display_categ_images,
-                'grey-border-bottom': env.pos.config.iface_display_categ_images,
-            }">
-                <!-- Breadcrumbs -->
-                <div class="breadcrumbs">
-                    <HomeCategoryBreadcrumb subcategories="props.subcategories" currentCat="props.breadcrumbs[props.breadcrumbs.length - 1]"/>
-                    <t t-if="!env.isMobile">
-                        <t t-foreach="props.breadcrumbs" t-as="category" t-key="category.id">
-                            <CategoryBreadcrumb category="category" />
+            <t t-if="!props.hasNoCategories">
+                <div class="rightpane-header" t-att-class="{
+                    'green-border-bottom': !env.pos.config.iface_display_categ_images,
+                    'grey-border-bottom': env.pos.config.iface_display_categ_images,
+                }">
+                    <!-- Breadcrumbs -->
+                    <div class="breadcrumbs">
+                        <HomeCategoryBreadcrumb subcategories="props.subcategories" currentCat="props.breadcrumbs[props.breadcrumbs.length - 1]"/>
+                        <t t-if="!env.isMobile">
+                            <t t-foreach="props.breadcrumbs" t-as="category" t-key="category.id">
+                                <CategoryBreadcrumb category="category" />
+                            </t>
+                        </t>
+                    </div>
+                    <!-- Subcategories -->
+                    <t t-if="props.subcategories.length > 0 and !env.pos.config.iface_display_categ_images and !env.isMobile">
+                        <t t-foreach="props.subcategories" t-as="category" t-key="category.id">
+                            <CategorySimpleButton category="category" />
                         </t>
                     </t>
                 </div>
-                <!-- Subcategories -->
-                <t t-if="props.subcategories.length > 0 and !env.pos.config.iface_display_categ_images and !env.isMobile">
-                    <t t-foreach="props.subcategories" t-as="category" t-key="category.id">
-                        <CategorySimpleButton category="category" />
-                    </t>
-                </t>
-            </div>
-            <t t-if="props.subcategories.length > 0 and env.pos.config.iface_display_categ_images and !env.isMobile">
-                <div class="categories">
-                    <div class="category-list-scroller">
-                        <div class="category-list">
-                            <t t-foreach="props.subcategories" t-as="category" t-key="category.id">
-                                <CategoryButton category="category" />
-                            </t>
+                <t t-if="props.subcategories.length > 0 and env.pos.config.iface_display_categ_images and !env.isMobile">
+                    <div class="categories">
+                        <div class="category-list-scroller">
+                            <div class="category-list">
+                                <t t-foreach="props.subcategories" t-as="category" t-key="category.id">
+                                    <CategoryButton category="category" />
+                                </t>
+                            </div>
                         </div>
                     </div>
-                </div>
+                </t>
             </t>
             <Portal target="'.pos .search-bar-portal'">
                 <div class="search-box">