From d73c841abf44d59114fc18e4af40c047dcef1ebc Mon Sep 17 00:00:00 2001
From: Swapnesh Shah <swapneshshah111@gmail.com>
Date: Sun, 20 Sep 2020 11:29:31 +0000
Subject: [PATCH] [IMP] survey: make error message required when validation is
 enabled

Before this commit *Validation Error message* was not required for questions
with *Validate Required*. This leads to having `False` displayed if
*Validation Error message* is empty.

With this commit we make *Validation Error message* required for these types
of questions which requires validation. Indeed it makes no sense to required
a validation but having no message explaning why it failed.

closes odoo/odoo#58083

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
---
 addons/survey/views/survey_question_views.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/survey/views/survey_question_views.xml b/addons/survey/views/survey_question_views.xml
index d9e7bedc9c1..69a76393306 100644
--- a/addons/survey/views/survey_question_views.xml
+++ b/addons/survey/views/survey_question_views.xml
@@ -124,7 +124,7 @@
                                             <field name="validation_max_date" attrs="{'invisible': [('question_type', '!=', 'date')]}"/>
                                             <field name="validation_min_datetime" widget="datetime" attrs="{'invisible': [('question_type', '!=', 'datetime')]}"/>
                                             <field name="validation_max_datetime" widget="datetime" attrs="{'invisible': [('question_type', '!=', 'datetime')]}"/>
-                                            <field name="validation_error_msg"/>
+                                            <field name="validation_error_msg" attrs="{'required': [('validation_required', '=', True)]}"/>
                                         </group>
                                     </div>
                                 </div>