From d70da05100c55526ff68020bf1824beba560ddea Mon Sep 17 00:00:00 2001
From: Elisabeth Dickinson <edi@odoo.com>
Date: Tue, 30 May 2023 12:35:00 +0000
Subject: [PATCH] [FIX] spreadsheet_dashboard: fix lost margins on dropdowns
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

During the Milk revamp, the dropdown items in the Dashboard's header
lost their horizontal margins. These have been put back by setting a gap
property to the parent.
When in the dashboard view under Sales > Product, the dropdowns had an
awkward spacing between them despite the fix. Another fix was to set
`w-100` to the `.o_field_tags` element. And finally a `.gap-1` is also
added to the latter to give its children some space when multiple tags
are selected.

It was noticed that some CSS, specifically the `.o-filter-value` class,
was not targeting anything. This has been fixed by moving the selector
into its correct parent element.

task-3326566
part of task-3326263

closes odoo/odoo#127010

X-original-commit: bd456bc89f896de6b3d8c040706dc02ab3799e6e
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
---
 .../components/records_selector/records_selector.xml      | 2 +-
 .../src/bundle/dashboard_action/dashboard_action.scss     | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/addons/spreadsheet/static/src/global_filters/components/records_selector/records_selector.xml b/addons/spreadsheet/static/src/global_filters/components/records_selector/records_selector.xml
index fbaf357baae..f485469f7a5 100644
--- a/addons/spreadsheet/static/src/global_filters/components/records_selector/records_selector.xml
+++ b/addons/spreadsheet/static/src/global_filters/components/records_selector/records_selector.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <templates>
     <div t-name="spreadsheet.RecordsSelector" class="o_field_widget o_field_many2many_tags" owl="1">
-        <div class="o_field_tags d-inline-flex flex-wrap mw-100 o_tags_input o_input">
+        <div class="o_field_tags d-inline-flex flex-wrap mw-100 o_tags_input o_input w-100 gap-1">
             <TagsList tags="tags"/>
             <div 
                 class="o_field_many2many_selection d-inline-flex w-100"
diff --git a/addons/spreadsheet_dashboard/static/src/bundle/dashboard_action/dashboard_action.scss b/addons/spreadsheet_dashboard/static/src/bundle/dashboard_action/dashboard_action.scss
index 483835a4fb9..af510297731 100644
--- a/addons/spreadsheet_dashboard/static/src/bundle/dashboard_action/dashboard_action.scss
+++ b/addons/spreadsheet_dashboard/static/src/bundle/dashboard_action/dashboard_action.scss
@@ -59,11 +59,13 @@
         align-items: flex-start;
         flex: 4;
         min-width: 0;
+    }
+
+    .o_control_panel_actions {
+        gap: map-get($spacers, 2);
 
         .o-filter-value {
             min-height: 25px;
-            margin-left: 8px;
-            margin-right: 8px;
             min-width: 100px;
 
             .o_field_many2many_tags {
@@ -73,7 +75,7 @@
             .o_field_many2manytags,
             .date_filter_values {
                 display: flex;
-                gap: 3px;
+                gap: map-get($spacers, 2);
                 align-items: baseline;
             }
         }