From d64c23df65e540027d4d5975c42bb6b9f966f3f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Theys?= Date: Thu, 11 Mar 2021 17:58:38 +0000 Subject: [PATCH] [FIX] web: prevent popover race condition between unmount and event These are throttled/debounced so the handlers are sometimes called after the component has been destroyed. opw-2451752 closes odoo/odoo#67754 X-original-commit: 852781cf64ad6bb10c552e106e93e2bb6035e34b Signed-off-by: Aaron Bohy (aab) --- addons/web/static/src/js/core/popover.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/addons/web/static/src/js/core/popover.js b/addons/web/static/src/js/core/popover.js index 9796916ab87..5dac00598b0 100644 --- a/addons/web/static/src/js/core/popover.js +++ b/addons/web/static/src/js/core/popover.js @@ -217,6 +217,9 @@ odoo.define('web.Popover', function (require) { * @param {Event} ev */ _onResizeWindow(ev) { + if (this.__owl__.status === 5 /* destroyed */) { + return; + } this._compute(); } @@ -228,6 +231,9 @@ odoo.define('web.Popover', function (require) { * @param {Event} ev */ _onScrollDocument(ev) { + if (this.__owl__.status === 5 /* destroyed */) { + return; + } this._compute(); }