From d599a05736dffb7222eeae7059dee19fd3c6f81c Mon Sep 17 00:00:00 2001 From: std-odoo Date: Tue, 24 Mar 2020 11:03:17 +0000 Subject: [PATCH] [FIX] website_blog: fix the share content popover widget Bug === We can not share a text with the "share content popover" widget if the text contains a single quote ('). Task-2223641 closes odoo/odoo#49515 X-original-commit: 58cba0f3139d8ac8fe561aac88af2a79a2703d50 Signed-off-by: Thibault Delavallee (tde) --- addons/website_blog/static/src/js/contentshare.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/addons/website_blog/static/src/js/contentshare.js b/addons/website_blog/static/src/js/contentshare.js index 76378524023..3c264cdcbdb 100644 --- a/addons/website_blog/static/src/js/contentshare.js +++ b/addons/website_blog/static/src/js/contentshare.js @@ -28,10 +28,11 @@ // Shorten the selected text to match the tweet max length // Note: all (non-localhost) urls in a tweet have 23 characters https://support.twitter.com/articles/78124 var selectedText = this.getSelection('string').substring(0, option.maxLength - baseLength - 23); - var text = encodeURIComponent(_.str.sprintf(tweet, selectedText, window.location.href)); - var $btn_t = $(''); - $btn_t.append($('')); - $popover_content.append($btn_t); + + var text = btoa(encodeURIComponent(_.str.sprintf(tweet, selectedText, window.location.href))); + $popover_content.append(_.str.sprintf( + "", + option.shareLink, text, option.target)); } return $popover_content; },