From d57c55c173a2dc1f9e7db48c08e5c9db8303af64 Mon Sep 17 00:00:00 2001
From: PoMa <poma@odoo.com>
Date: Wed, 17 Aug 2022 15:32:54 +0000
Subject: [PATCH] [IMP] account: UX improvements

Remove quick create from the places that is either not needed or not possible
Task #2850996

closes odoo/odoo#104640

X-original-commit: ae0a11a8ce3c35542ba5ae8f6366018b88ec40d5
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Pouya Malekinejad (poma) <poma@odoo.com>
---
 addons/account/views/account_account_views.xml         | 2 +-
 addons/account/views/account_journal_views.xml         | 8 +++++---
 addons/account/views/account_payment_view.xml          | 2 ++
 addons/account/views/account_reconcile_model_views.xml | 1 +
 4 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/addons/account/views/account_account_views.xml b/addons/account/views/account_account_views.xml
index 911bd57c607..402e942dfbb 100644
--- a/addons/account/views/account_account_views.xml
+++ b/addons/account/views/account_account_views.xml
@@ -60,7 +60,7 @@
                                 <group>
                                     <group>
                                         <field name="account_type" widget="account_type_selection"/>
-                                        <field name="tax_ids" widget="many2many_tags" domain="[('company_id','=',company_id)]" attrs="{'invisible': [('internal_group', '=', 'off_balance')]}"/>
+                                        <field name="tax_ids" widget="many2many_tags" domain="[('company_id','=',company_id)]" attrs="{'invisible': [('internal_group', '=', 'off_balance')]}" options="{'no_quick_create': True}"/>
                                         <field name="tag_ids" widget="many2many_tags" domain="[('applicability', '=', 'accounts')]" context="{'default_applicability': 'accounts'}" options="{'no_create_edit': True}"/>
                                         <field name="allowed_journal_ids" widget="many2many_tags" domain="[('company_id','=',company_id)]" options="{'no_create_edit': True}"/>
                                     </group>
diff --git a/addons/account/views/account_journal_views.xml b/addons/account/views/account_journal_views.xml
index d9c668b1409..6469087f6d0 100644
--- a/addons/account/views/account_journal_views.xml
+++ b/addons/account/views/account_journal_views.xml
@@ -115,6 +115,7 @@
                                                placeholder="Leave empty to use the default outstanding account"
                                                string="Outstanding Receipts accounts"
                                                optional="hide"
+                                               options="{'no_quick_create': True}"
                                                groups="account.group_account_readonly"/>
                                     </tree>
                                 </field>
@@ -132,6 +133,7 @@
                                                    placeholder="Leave empty to use the default outstanding account"
                                                    string="Outstanding Payments accounts"
                                                    optional="hide"
+                                                   options="{'no_quick_create': True}"
                                                    groups="account.group_account_readonly"/>
                                         </tree>
                                     </field>
@@ -142,7 +144,7 @@
                                 <group>
                                     <group string="Control-Access" groups="account.group_account_manager">
                                         <div class="text-muted" colspan="2">Keep empty for no control</div>
-                                        <field name="account_control_ids" widget="many2many_tags"/>
+                                        <field name="account_control_ids" widget="many2many_tags" options="{'no_create_edit': True}"/>
                                         <field name="restrict_mode_hash_table" groups="account.group_account_readonly" attrs="{'invisible': [('type', 'in', ['bank', 'cash'])]}"/>
                                     </group>
                                     <!-- email alias -->
@@ -166,8 +168,8 @@
                                         <field name="invoice_reference_model" attrs="{'invisible': [('invoice_reference_type', '=', 'none')]}"/>
                                     </group>
                                     <group string="Follow Customer Payments" attrs="{'invisible': [('type', '!=', 'sale')]}">
-                                        <field name="sale_activity_type_id"/>
-                                        <field name="sale_activity_user_id" attrs="{'invisible': [('sale_activity_type_id', '=', False)]}"/>
+                                        <field name="sale_activity_type_id" options="{'no_quick_create': True}"/>
+                                        <field name="sale_activity_user_id" attrs="{'invisible': [('sale_activity_type_id', '=', False)]}" options="{'no_quick_create': True}"/>
                                         <field name="sale_activity_note" placeholder="e.g. Give a phone call, check with others , ..."  attrs="{'invisible': [('sale_activity_type_id', '=', False)]}"/>
                                     </group>
                                 </group>
diff --git a/addons/account/views/account_payment_view.xml b/addons/account/views/account_payment_view.xml
index 917312683fe..a1afe015ab4 100644
--- a/addons/account/views/account_payment_view.xml
+++ b/addons/account/views/account_payment_view.xml
@@ -249,9 +249,11 @@
                                 <field name="payment_type" widget="radio" options="{'horizontal': True}"
                                         attrs="{'readonly': [('state', '!=', 'draft')]}"/>
                                 <field name="partner_id" context="{'default_is_company': True}" string="Customer"
+                                       options="{'no_quick_create': True}"
                                        attrs="{'readonly':[('state', '!=', 'draft')],
                                              'invisible':['|', ('partner_type','!=','customer'), ('is_internal_transfer', '=', True)]}"/>
                                 <field name="partner_id" context="{'default_is_company': True}" string="Vendor"
+                                       options="{'no_quick_create': True}"
                                        attrs="{'readonly':[('state', '!=', 'draft')],
                                                'invisible':['|', ('partner_type','!=','supplier'), ('is_internal_transfer', '=', True)]}"/>
                                 <label for="amount"/>
diff --git a/addons/account/views/account_reconcile_model_views.xml b/addons/account/views/account_reconcile_model_views.xml
index 662f8edf4e0..b0e2543b5a3 100644
--- a/addons/account/views/account_reconcile_model_views.xml
+++ b/addons/account/views/account_reconcile_model_views.xml
@@ -153,6 +153,7 @@
                                                attrs="{'invisible': ['|', ('match_partner', '=', False), ('rule_type', '=', 'writeoff_button')]}"/>
                                         <field name="match_partner_ids" nolabel="1"
                                                widget="many2many_tags"
+                                               options="{'no_quick_create': True}"
                                                attrs="{'invisible': ['|', ('match_partner', '=', False), ('rule_type', '=', 'writeoff_button')]}"/>
                                         <label for="match_partner_category_ids" class="ml16"
                                                attrs="{'invisible': ['|', ('match_partner', '=', False), ('rule_type', '=', 'writeoff_button')]}"/>