From d418bff698f1601d7d3b2d1579d785e47f4f47d1 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Wed, 8 Jan 2020 14:42:49 +0000 Subject: [PATCH] [FIX] core: make accessing fields from __str__ possible Because CacheMiss calls str() on the record it's given, it's not possible to override __str__ and get field values: on the first cache miss (= the first field access) we're going to blow the stack: * any random field is accessed * and faults * which creates a CacheMiss * which stringifies the record * which accesses a field * which faults * which creates a CacheMiss * etc... Fix: * move the basic Model's stringification to repr(), which is implicitly called on str() if no __str__ is specified, for historical reasons we were doing the opposite * use repr() when initialising CacheMiss closes odoo/odoo#42966 Signed-off-by: Xavier Morel (xmo) --- odoo/exceptions.py | 2 +- odoo/models.py | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/odoo/exceptions.py b/odoo/exceptions.py index 17a3d89ede8..93a0a84e20f 100644 --- a/odoo/exceptions.py +++ b/odoo/exceptions.py @@ -104,7 +104,7 @@ class CacheMiss(except_orm, KeyError): """ def __init__(self, record, field): - super(CacheMiss, self).__init__("%s.%s" % (str(record), field.name)) + super(CacheMiss, self).__init__("%r.%s" % (record, field.name)) class MissingError(except_orm): diff --git a/odoo/models.py b/odoo/models.py index 3a602f2bff6..38ce123c2be 100644 --- a/odoo/models.py +++ b/odoo/models.py @@ -5665,10 +5665,8 @@ Record ids: %(records)s def __int__(self): return self.id or 0 - def __str__(self): - return "%s%s" % (self._name, getattr(self, '_ids', "")) def __repr__(self): - return str(self) + return "%s%s" % (self._name, getattr(self, '_ids', "")) def __hash__(self): if hasattr(self, '_ids'):