From d401f368c2c14b03738045bc8e6c58f5ba7637cd Mon Sep 17 00:00:00 2001 From: Bruno Boi Date: Fri, 8 Sep 2023 11:50:08 +0200 Subject: [PATCH] [FIX] test_base_automation: fix failing tour This commit fixes a tour that is failing undeterministically. - Before The tour was saving a form dialog just before saving the main form. Sometimes, these two steps were too fast, leading for the second one not performing the main form save action. - After The second step now awaits that the modal is closed before running. This element is the kanban record saved by the form dialog. Fixes runbot error 24576 closes odoo/odoo#134776 Signed-off-by: Lucas Perais (lpe) --- .../static/tests/tour/base_automation_tour.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/test_base_automation/static/tests/tour/base_automation_tour.js b/addons/test_base_automation/static/tests/tour/base_automation_tour.js index dd9c71405c7..c771f50e748 100644 --- a/addons/test_base_automation/static/tests/tour/base_automation_tour.js +++ b/addons/test_base_automation/static/tests/tour/base_automation_tour.js @@ -99,7 +99,9 @@ registry.category("web_tour.tours").add("test_base_automation", { content: "Open update select", trigger: ".modal-content .o_form_button_save", }, - ...stepUtils.saveForm(), + ...stepUtils.saveForm({ + extra_trigger: ".o-overlay-container:not(:has(.modal-content))", + }), ], });